Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 989093002: Do not set target in deoptimized code in keyed store IC. (Closed)

Created:
5 years, 9 months ago by Jarin
Modified:
5 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not set target in deoptimized code in keyed store IC. BUG=chromium:460937 R=ishell@chromium.org LOG=n Committed: https://crrev.com/82a28adf059a6b5205a292233c416bd307f4cf8e Cr-Commit-Position: refs/heads/master@{#27064}

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M src/ic/ic.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-460937.js View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jarin
Could you take a look, please?
5 years, 9 months ago (2015-03-08 19:07:07 UTC) #1
Igor Sheludko
lgtm
5 years, 9 months ago (2015-03-09 08:58:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989093002/20001
5 years, 9 months ago (2015-03-09 09:25:36 UTC) #4
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 09:26:41 UTC) #6
Jarin
Committed patchset #2 (id:20001) manually as 82a28adf059a6b5205a292233c416bd307f4cf8e (presubmit successful).
5 years, 9 months ago (2015-03-09 10:11:18 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 10:11:22 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82a28adf059a6b5205a292233c416bd307f4cf8e
Cr-Commit-Position: refs/heads/master@{#27064}

Powered by Google App Engine
This is Rietveld 408576698