src/ic/ic.cc - Issue 989093002: Do not set target in deoptimized code in keyed store IC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 989093002: Do not set target in deoptimized code in keyed store IC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index f896d16cabf2ca055a8e9d63bd60e538817fc830..41f2a334aabc709a3c2451efe9cfe3e274822559 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -2181,7 +2181,9 @@ MaybeHandle<Object> KeyedStoreIC::Store(Handle<Object> object,

TRACE_GENERIC_IC(isolate(), "KeyedStoreIC", "slow stub");

}

DCHECK(!stub.is_null());

- set_target(*stub);

+ if (!AddressIsDeoptimizedCode()) {

+ set_target(*stub);

+ }

TRACE_IC("StoreIC", key);

return store_handle;

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-460937.js » ('j') | no next file with comments »