Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 988763002: Start separating the text track container from the media controls (Closed)

Created:
5 years, 9 months ago by fs
Modified:
5 years, 9 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, blink-reviews-rendering, philipj_slow, feature-media-reviews_chromium.org, gasubic, sof, eae+blinkwatch, fs, eric.carlson_apple.com, leviw+renderwatch, Dominik Röttsches, blink-reviews-dom_chromium.org, dglazkov+blink, nessy, jchaffraix+rendering, pdr+renderingwatchlist_chromium.org, blink-reviews-html_chromium.org, zoltan1, vcarbune.chromium, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Start separating the text track container from the media controls Having the text track container as a part of the media controls makes it harder to show and hide the controls as a group, which would be useful. This CL prepares for this by moving and renaming code, with no observable difference. However, some small drive-by fixes are included: TextTrackContainer::m_videoDisplaySize is made into an IntSize, since the position part is never used. It's also renamed to just m_videoSize. (Based on https://codereview.chromium.org/949203002/) BUG=448795 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191538

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -300 lines) Patch
M Source/core/core.gypi View 1 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/dom/Node.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 chunks +8 lines, -2 lines 0 comments Download
M Source/core/html/shadow/MediaControlElementTypes.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/MediaControlElements.h View 1 1 chunk +0 lines, -19 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 1 2 chunks +0 lines, -119 lines 0 comments Download
M Source/core/html/shadow/MediaControls.h View 4 chunks +3 lines, -4 lines 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 1 5 chunks +14 lines, -21 lines 0 comments Download
A + Source/core/html/track/TextTrackContainer.h View 1 2 chunks +23 lines, -10 lines 0 comments Download
A Source/core/html/track/TextTrackContainer.cpp View 1 1 chunk +153 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutMediaControls.cpp View 1 chunk +0 lines, -1 line 0 comments Download
A + Source/core/layout/LayoutTextTrackContainer.h View 1 chunk +7 lines, -9 lines 0 comments Download
A + Source/core/layout/LayoutTextTrackContainer.cpp View 1 chunk +10 lines, -8 lines 0 comments Download
D Source/core/layout/LayoutTextTrackContainerElement.h View 1 chunk +0 lines, -49 lines 0 comments Download
D Source/core/layout/LayoutTextTrackContainerElement.cpp View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
fs
https://codereview.chromium.org/988763002/diff/1/Source/core/layout/LayoutTextTrackContainer.cpp File Source/core/layout/LayoutTextTrackContainer.cpp (right): https://codereview.chromium.org/988763002/diff/1/Source/core/layout/LayoutTextTrackContainer.cpp#newcode53 Source/core/layout/LayoutTextTrackContainer.cpp:53: LayoutObject* mediaElementLayoutObject = parent()->parent()->parent(); Had to get a bit ...
5 years, 9 months ago (2015-03-06 17:50:03 UTC) #2
philipj_slow
lgtm https://codereview.chromium.org/988763002/diff/1/Source/core/layout/LayoutTextTrackContainer.cpp File Source/core/layout/LayoutTextTrackContainer.cpp (right): https://codereview.chromium.org/988763002/diff/1/Source/core/layout/LayoutTextTrackContainer.cpp#newcode53 Source/core/layout/LayoutTextTrackContainer.cpp:53: LayoutObject* mediaElementLayoutObject = parent()->parent()->parent(); On 2015/03/06 17:50:03, fs ...
5 years, 9 months ago (2015-03-06 18:12:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988763002/1
5 years, 9 months ago (2015-03-06 18:13:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/46316)
5 years, 9 months ago (2015-03-06 20:01:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988763002/20001
5 years, 9 months ago (2015-03-09 10:34:00 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 12:05:04 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191538

Powered by Google App Engine
This is Rietveld 408576698