Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: Source/core/html/shadow/MediaControls.h

Issue 988763002: Start separating the text track container from the media controls (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/shadow/MediaControlElements.cpp ('k') | Source/core/html/shadow/MediaControls.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/shadow/MediaControls.h
diff --git a/Source/core/html/shadow/MediaControls.h b/Source/core/html/shadow/MediaControls.h
index e4b400674249c1a680dd41a7d714d5b5424f7f70..db9593b0b24afa51360b933ba8f6b96fc0e0a246 100644
--- a/Source/core/html/shadow/MediaControls.h
+++ b/Source/core/html/shadow/MediaControls.h
@@ -33,6 +33,7 @@
namespace blink {
class Event;
+class TextTrackContainer;
class MediaControls final : public HTMLDivElement {
public:
@@ -67,7 +68,7 @@ public:
void refreshCastButtonVisibility();
void showOverlayCastButton();
- void updateTextTrackDisplay();
+ TextTrackContainer* textTrackContainer();
void mediaElementFocused();
@@ -100,8 +101,6 @@ private:
// element in the page, it will be hidden.
void tryShowOverlayCastButton();
- void createTextTrackDisplay();
-
// Node
virtual bool isMediaControls() const override { return true; }
virtual bool willRespondToMouseMoveEvents() override { return true; }
@@ -114,7 +113,7 @@ private:
RawPtrWillBeMember<MediaControlPanelElement> m_panel;
// Container for the text track cues.
- RawPtrWillBeMember<MediaControlTextTrackContainerElement> m_textDisplayContainer;
+ RawPtrWillBeMember<TextTrackContainer> m_textTrackContainer;
// Media control elements.
RawPtrWillBeMember<MediaControlOverlayPlayButtonElement> m_overlayPlayButton;
« no previous file with comments | « Source/core/html/shadow/MediaControlElements.cpp ('k') | Source/core/html/shadow/MediaControls.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698