Make inference defaults consts for easy tweaking

Make inference defaults consts for easy tweaking

R=sigmund@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/89c3a7ffde1bb9d745a04467ab7c0d2a805df02d

[vsm, 2015-03-06 19:04:12]

vsm@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-03-06 19:21:20]

lgtm

https://codereview.chromium.org/988743003/diff/1/lib/src/options.dart
File lib/src/options.dart (right):

https://codereview.chromium.org/988743003/diff/1/lib/src/options.dart#newcode40
lib/src/options.dart:40: static const INFER_STATICS_FROM_IDENTIFIERS_DEFAULT =
false;
BTW - I think we are moving away from using ALL_CAPS for constants
(https://www.dartlang.org/articles/style-guide/#prefer-using-lowercamelcase-fo...).

One way to do that here would be to move these constants to a separate class,
for example:

  class Defaults {
    static const inferFromOverrides = false;
  }


then the initialization calls would look more like this:

  ...
  this.inferFromOverrides: Defaults.inferFromOverrides,
  ...

https://codereview.chromium.org/988743003/diff/1/lib/src/options.dart#newcode216
lib/src/options.dart:216: this.onlyInferConstsAndFinalFields:
ResolverOptions.ONLY_INFER_CONSTS_AND_FINAL_FIELDS,
might need to run the formatter :)

[vsm, 2015-03-06 20:38:17]

https://codereview.chromium.org/988743003/diff/1/lib/src/options.dart
File lib/src/options.dart (right):

https://codereview.chromium.org/988743003/diff/1/lib/src/options.dart#newcode40
lib/src/options.dart:40: static const INFER_STATICS_FROM_IDENTIFIERS_DEFAULT =
false;
On 2015/03/06 19:21:20, Siggi Cherem (dart-lang) wrote:
> BTW - I think we are moving away from using ALL_CAPS for constants
>
(https://www.dartlang.org/articles/style-guide/#prefer-using-lowercamelcase-fo...).
> 
> One way to do that here would be to move these constants to a separate class,
> for example:
> 
>   class Defaults {
>     static const inferFromOverrides = false;
>   }
> 
> 
> then the initialization calls would look more like this:
> 
>   ...
>   this.inferFromOverrides: Defaults.inferFromOverrides,
>   ...

Done on lowerCamelCase.  Didn't break these into a separate class ... seems
nicer to have the defaults next to the comments.

https://codereview.chromium.org/988743003/diff/1/lib/src/options.dart#newcode216
lib/src/options.dart:216: this.onlyInferConstsAndFinalFields:
ResolverOptions.ONLY_INFER_CONSTS_AND_FINAL_FIELDS,
On 2015/03/06 19:21:20, Siggi Cherem (dart-lang) wrote:
> might need to run the formatter :)

I did - it seems to prefer this?

[vsm, 2015-03-06 20:38:32]

Committed patchset #2 (id:20001) manually as
89c3a7ffde1bb9d745a04467ab7c0d2a805df02d (presubmit successful).