Make inference defaults consts for easy tweaking

lib/src/options.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Set of flags and options passed to the compiler
 library dev_compiler.src.options;
 
 import 'dart:io';
 
 import 'package:args/args.dart';
 import 'package:cli_util/cli_util.dart' show getSdkDir;
 import 'package:dev_compiler/config.dart';
 import 'package:logging/logging.dart' show Level;
 
 /// Options used by our TypeResolver.
 class ResolverOptions {
   /// Whether to resolve 'package:' uris using the multi-package resolver.
   final bool useMultiPackage;
 
   /// Package root when resolving 'package:' urls the standard way.
   final String packageRoot;
 
   /// List of paths used for the multi-package resolver.
   final List<String> packagePaths;
 
   /// Whether to infer return types and field types from overriden members.
   final bool inferFromOverrides;
-  static const bool INFER_FROM_OVERRIDES_DEFAULT = false;
+  static const INFER_FROM_OVERRIDES_DEFAULT = false;
 
   /// Whether to infer types for consts and static fields by looking at
   /// identifiers on the RHS. For example, in a constant declaration like:
   ///
   ///      const A = B;
   ///
   /// We can infer the type of `A` based on the type of `B`. The current
   /// implementation of this inference is limited and will only work if `B` is
   /// defined in a different library than `A`. Because this might be surprising
   /// to users, this is turned off by default.
   final bool inferStaticsFromIdentifiers;
+  static const INFER_STATICS_FROM_IDENTIFIERS_DEFAULT = false;

[Siggi Cherem (dart-lang), 2015/03/06 19:21:20]

BTW - I think we are moving away from using ALL_CAPS for constants
(https://www.dartlang.org/articles/style-guide/#prefer-using-lowercamelcase-fo...).

One way to do that here would be to move these constants to a separate class,
for example:

  class Defaults {
    static const inferFromOverrides = false;
  }


then the initialization calls would look more like this:

  ...
  this.inferFromOverrides: Defaults.inferFromOverrides,
  ...

[vsm, 2015/03/06 20:38:16]

Done on lowerCamelCase.  Didn't break these into a separate class ... seems
nicer to have the defaults next to the comments.

 
   /// Whether to ignore ordering issues and do a best effort in inference. When
   /// false, inference of top-levels and statics is limited to only consider
   /// expressions in the RHS for which the type is known precisely without
   /// regard of the ordering in which we apply inference. Turning this flag on
   /// will consider more expressions, including expressions where the RHS is
   /// another identifier (which [inferStaticsFromIdentifiers]).
   ///
   /// Note: this option is experimental will be removed once we have a proper
   /// implementation of inference in the future, which should handle all
   /// ordering concerns.
   final bool inferInNonStableOrder;
+  static const INFER_IN_NON_STABLE_ORDER = false;
 
   /// Restrict inference of fields and top-levels to those that are final and
   /// const.
   final bool onlyInferConstsAndFinalFields;
+  static const ONLY_INFER_CONSTS_AND_FINAL_FIELDS = false;
 
   ResolverOptions({this.useMultiPackage: false, this.packageRoot: 'packages/',
       this.packagePaths: const <String>[],
       this.inferFromOverrides: INFER_FROM_OVERRIDES_DEFAULT,
-      this.inferStaticsFromIdentifiers: false,
-      this.inferInNonStableOrder: false,
-      this.onlyInferConstsAndFinalFields: false});
+      this.inferStaticsFromIdentifiers: INFER_STATICS_FROM_IDENTIFIERS_DEFAULT,
+      this.inferInNonStableOrder: INFER_IN_NON_STABLE_ORDER,
+      this.onlyInferConstsAndFinalFields: ONLY_INFER_CONSTS_AND_FINAL_FIELDS});
 }
 
 // TODO(vsm): Merge RulesOptions and TypeOptions
 /// Options used by our RestrictedRules.
 class RulesOptions extends TypeOptions {
   /// Whether to allow casts in constant contexts.
   final bool allowConstCasts;
 
   /// Whether to use covariant generics
   final bool covariantGenerics;
@@ skipping 128 matching lines @@
 
   CompilerOptions({this.allowConstCasts: true, this.checkSdk: false,
       this.dumpInfo: false, this.dumpInfoFile, this.dumpSrcDir,
       this.forceCompile: false, this.formatOutput: false,
       this.cheapTestFormat: false, this.ignoreTypes: false, this.outputDir,
       this.outputDart: false, this.useColors: true,
       this.covariantGenerics: true, this.relaxedCasts: true,
       this.useMultiPackage: false, this.packageRoot: 'packages/',
       this.packagePaths: const <String>[],
       this.inferFromOverrides: ResolverOptions.INFER_FROM_OVERRIDES_DEFAULT,
-      this.inferStaticsFromIdentifiers: false,
-      this.inferInNonStableOrder: false,
-      this.onlyInferConstsAndFinalFields: false,
+      this.inferStaticsFromIdentifiers: ResolverOptions.INFER_STATICS_FROM_IDENTIFIERS_DEFAULT,
+      this.inferInNonStableOrder: ResolverOptions.INFER_IN_NON_STABLE_ORDER,
+      this.onlyInferConstsAndFinalFields: ResolverOptions.ONLY_INFER_CONSTS_AND_FINAL_FIELDS,

[Siggi Cherem (dart-lang), 2015/03/06 19:21:20]

might need to run the formatter :)

[vsm, 2015/03/06 20:38:16]

I did - it seems to prefer this?

       this.nonnullableTypes: TypeOptions.NONNULLABLE_TYPES, this.help: false,
       this.useMockSdk: false, this.dartSdkPath, this.logLevel: Level.SEVERE,
       this.emitSourceMaps: true, this.entryPointFile: null,
       this.serverMode: false, this.port: 8080});
 }
 
 /// Parses options from the command-line
 CompilerOptions parseOptions(List<String> argv) {
   ArgResults args = argParser.parse(argv);
   var levelName = args['log'].toUpperCase();
@@ skipping 53 matching lines @@
   ..addOption('nonnullable',
       abbr: 'n',
       help: 'Comma separated string of non-nullable types',
       defaultsTo: null)
   ..addFlag('infer-from-overrides',
       help: 'Infer unspecified types of fields and return types from '
       'definitions in supertypes',
       defaultsTo: ResolverOptions.INFER_FROM_OVERRIDES_DEFAULT)
   ..addFlag('infer-transitively',
       help: 'Infer consts/fields from definitions in other libraries',
-      defaultsTo: false)
+      defaultsTo: ResolverOptions.INFER_STATICS_FROM_IDENTIFIERS_DEFAULT)
   ..addFlag('infer-only-finals',
-      help: 'Do not infer non-const or non-final fields', defaultsTo: false)
+      help: 'Do not infer non-const or non-final fields',
+      defaultsTo: ResolverOptions.ONLY_INFER_CONSTS_AND_FINAL_FIELDS)
   ..addFlag('infer-eagerly',
       help: 'experimental: allows a non-stable order of transitive inference on'
       ' consts and fields. This is used to test for possible inference with a '
-      'proper implementation in the future.', defaultsTo: false)
+      'proper implementation in the future.',
+      defaultsTo: ResolverOptions.INFER_IN_NON_STABLE_ORDER)
 
   // input/output options
   ..addOption('out', abbr: 'o', help: 'Output directory', defaultsTo: null)
   ..addOption('dart-sdk', help: 'Dart SDK Path', defaultsTo: null)
   ..addFlag('dart-gen',
       abbr: 'd', help: 'Generate dart output', defaultsTo: false)
   ..addFlag('dart-gen-fmt',
       help: 'Generate readable dart output', defaultsTo: true)
   ..addOption('dump-src-to', help: 'Dump dart src code', defaultsTo: null)
   ..addOption('package-root',
@@ skipping 16 matching lines @@
       defaultsTo: '8080')
   ..addFlag('force-compile',
       help: 'Compile code with static errors', defaultsTo: false)
   ..addOption('log', abbr: 'l', help: 'Logging level', defaultsTo: 'severe')
   ..addFlag('dump-info',
       abbr: 'i', help: 'Dump summary information', defaultsTo: false)
   ..addOption('dump-info-file',
       abbr: 'f',
       help: 'Dump info json file (requires dump-info)',
       defaultsTo: null);