Test dead code.

Test dead code.

Test a log method that could be helpful for debugging.  Also inline SpdyPriorityIR constructors for code convergence.

This CL lands server change 87053738 by birenroy.

BUG=

Committed: https://crrev.com/e44eb0a35c11f8ff743873f5f382b5d5c5353325
Cr-Commit-Position: refs/heads/master@{#319724}

Committed: https://crrev.com/d53c312f4d645e2f5ad94e6734102df34e330001
Cr-Commit-Position: refs/heads/master@{#320215}

[Bence, 2015-03-09 14:22:05]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2015-03-09 14:22:05]

Ryan, PTAL.  Thanks.

[Ryan Hamilton, 2015-03-09 17:44:29]

lgtm

[Bence, 2015-03-09 18:00:08]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2015-03-09 18:00:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/988733003/60001

[commit-bot: I haz the power, 2015-03-09 20:28:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-09 20:29:08]

Patchset 4 (id:??) landed as
https://crrev.com/e44eb0a35c11f8ff743873f5f382b5d5c5353325
Cr-Commit-Position: refs/heads/master@{#319724}

[dgrogan, 2015-03-09 21:22:28]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/992613005/ by dgrogan@chromium.org.

The reason for reverting is: Broke "compile" on "iOS_Device".

http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/26659/ste...

Undefined symbols for architecture armv7:
  "net::SpdyPriorityIR::SpdyPriorityIR(unsigned int, unsigned int, unsigned
char, bool)", referenced from:
      net::SpdyFramerTest_CreatePriority_Test::TestBody() in spdy_framer_test.o
      net::SpdyFramerTest_ReadPriority_Test::TestBody() in spdy_framer_test.o
ld: symbol(s) not found for architecture armv7
clang:error: linker command failed with exit code 1 (use -v to see invocation).

[Bence, 2015-03-11 23:24:23]

The CQ bit was checked by bnc@chromium.org

[Bence, 2015-03-11 23:24:46]

On 2015/03/09 21:22:28, dgrogan wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/992613005/ by mailto:dgrogan@chromium.org.
> 
> The reason for reverting is: Broke "compile" on "iOS_Device".
> 
>
http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/26659/ste...
> 
> Undefined symbols for architecture armv7:
>   "net::SpdyPriorityIR::SpdyPriorityIR(unsigned int, unsigned int, unsigned
> char, bool)", referenced from:
>       net::SpdyFramerTest_CreatePriority_Test::TestBody() in
spdy_framer_test.o
>       net::SpdyFramerTest_ReadPriority_Test::TestBody() in spdy_framer_test.o
> ld: symbol(s) not found for architecture armv7
> clang:error: linker command failed with exit code 1 (use -v to see
invocation).

Above compile problem was infrastructure related, retrying after two days.

[Bence, 2015-03-11 23:24:48]

On 2015/03/09 21:22:28, dgrogan wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/992613005/ by mailto:dgrogan@chromium.org.
> 
> The reason for reverting is: Broke "compile" on "iOS_Device".
> 
>
http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/26659/ste...
> 
> Undefined symbols for architecture armv7:
>   "net::SpdyPriorityIR::SpdyPriorityIR(unsigned int, unsigned int, unsigned
> char, bool)", referenced from:
>       net::SpdyFramerTest_CreatePriority_Test::TestBody() in
spdy_framer_test.o
>       net::SpdyFramerTest_ReadPriority_Test::TestBody() in spdy_framer_test.o
> ld: symbol(s) not found for architecture armv7
> clang:error: linker command failed with exit code 1 (use -v to see
invocation).

Above compile problem was infrastructure related, retrying after two days.

[commit-bot: I haz the power, 2015-03-11 23:24:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/988733003/60001

[commit-bot: I haz the power, 2015-03-12 02:58:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-12 02:59:18]

Patchset 4 (id:??) landed as
https://crrev.com/d53c312f4d645e2f5ad94e6734102df34e330001
Cr-Commit-Position: refs/heads/master@{#320215}