Chromium roll (https://codereview.chromium.org/976353002)

mojo/tools/roll/disable_find_bad_constructs.patch

Index: mojo/tools/roll/disable_find_bad_constructs.patch
diff --git a/mojo/tools/roll/disable_find_bad_constructs.patch b/mojo/tools/roll/disable_find_bad_constructs.patch
new file mode 100644
index 0000000000000000000000000000000000000000..e692319c673dfdd2c2ddee91b312b8870d9917cd
--- /dev/null
+++ b/mojo/tools/roll/disable_find_bad_constructs.patch
@@ -0,0 +1,12 @@
+diff --git a/build/config/clang/BUILD.gn b/build/config/clang/BUILD.gn
+index 39fe251..62e6108 100644
+--- a/build/config/clang/BUILD.gn
++++ b/build/config/clang/BUILD.gn
+@@ -26,7 +26,6 @@ config("find_bad_constructs") {
+       "-Xclang",
+       "-add-plugin",
+       "-Xclang",

[jamesr, 2015/03/10 21:42:14]

what this block used to do was add

"-Xclang -add-plugin -Xclang find-bad-constructs"

The -Xclang prefixes said to pass along the command to clang, so this really
meant

"-add-plugin find-bad-constructs"

you've now changed this to say

"-Xclang -add-plugin -Xclang"

so whatever argument comes after this will be misinterpreted as a plugin to
attempt to add.  That's not what you want I'm sure. instead you should patch
this to not add anything.

+-      "find-bad-constructs",
+     ]
+   }
+ }