mojo/tools/roll/disable_find_bad_constructs.patch - Issue 988693005: Chromium roll (https://codereview.chromium.org/976353002)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/tools/roll/disable_find_bad_constructs.patch

Issue 988693005: Chromium roll (https://codereview.chromium.org/976353002) (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Android build fix Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 diff --git a/build/config/clang/BUILD.gn b/build/config/clang/BUILD.gn

	2 index 39fe251..62e6108 100644

	3 --- a/build/config/clang/BUILD.gn

	4 +++ b/build/config/clang/BUILD.gn

	5 @@ -26,7 +26,6 @@ config("find_bad_constructs") {

	6 "-Xclang",

	7 "-add-plugin",

	8 "-Xclang",
	jamesr 2015/03/10 21:42:14 what this block used to do was add "-Xclang -add- what this block used to do was add "-Xclang -add-plugin -Xclang find-bad-constructs" The -Xclang prefixes said to pass along the command to clang, so this really meant "-add-plugin find-bad-constructs" you've now changed this to say "-Xclang -add-plugin -Xclang" so whatever argument comes after this will be misinterpreted as a plugin to attempt to add. That's not what you want I'm sure. instead you should patch this to not add anything.
	9 - "find-bad-constructs",

	10 ]

	11 }

	12 }

OLD	NEW

« no previous file with comments | « mojo/tools/roll/cc_strip_video.patch ('k') | sandbox/linux/BUILD.gn » ('j') | no next file with comments »