LayoutTests/fast/css/auto-min-size.html - Issue 988523003: Reimplement min-width: auto

Unified Diff: LayoutTests/fast/css/auto-min-size.html

Issue 988523003: Reimplement min-width: auto (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebased Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/fast/css/auto-min-size.html

diff --git a/LayoutTests/fast/css/auto-min-size.html b/LayoutTests/fast/css/auto-min-size.html

index aae4e78861e4a368a487de1f00a331fb1b7b1d7f..38d248a8091d49d249d26b4823df228e69f42010 100644

--- a/LayoutTests/fast/css/auto-min-size.html

+++ b/LayoutTests/fast/css/auto-min-size.html

@@ -6,27 +6,26 @@ div = document.getElementById('foo');

shouldBe('div.style.minWidth', '""');

shouldBe('getComputedStyle(div)["min-width"]', '"0px"');

+div.style.minWidth = 0;

+shouldBe('div.style.minWidth', '"0px"');

+shouldBe('getComputedStyle(div)["min-width"]', '"0px"');

Julien - ping for review 2015/04/06 17:06:47 Why was this code moved? It doesn't seem any more

cbiesinger 2015/04/06 21:34:16 Hmm good question. I started out with this patch b

div.style.minWidth = 'auto';

div.style.maxWidth = 'auto';

-shouldBe('div.style.minWidth', '""');

+shouldBe('div.style.minWidth', '"auto"');

shouldBe('div.style.maxWidth', '""');

shouldBe('getComputedStyle(div).minWidth', '"0px"');

-div.style.minWidth = 0;

-shouldBe('div.style.minWidth', '"0px"');

-shouldBe('getComputedStyle(div)["min-width"]', '"0px"');

shouldBe('div.style.minHeight', '""');

shouldBe('getComputedStyle(div)["min-height"]', '"0px"');

-div.style.minHeight = 'auto';

-div.style.maxHeight = 'auto';

-shouldBe('div.style.minHeight', '""');

-shouldBe('div.style.maxHeight', '""');

-shouldBe('getComputedStyle(div).minHeight', '"0px"');

div.style.minHeight = 0;

shouldBe('div.style.minHeight', '"0px"');

shouldBe('getComputedStyle(div)["min-height"]', '"0px"');

+div.style.minHeight = 'auto';

+div.style.maxHeight = 'auto';

+shouldBe('div.style.minHeight', '"auto"');

+shouldBe('div.style.maxHeight', '""');

Julien - ping for review 2015/04/06 17:06:47 This is surprising as max-height should be 'auto'

cbiesinger 2015/04/06 21:34:16 auto is not a valid value for max-height/max-width

+shouldBe('getComputedStyle(div).minHeight', '"0px"');

</script>