LayoutTests/fast/css/auto-min-size.html - Issue 988523003: Reimplement min-width: auto

Side by Side Diff: LayoutTests/fast/css/auto-min-size.html

Issue 988523003: Reimplement min-width: auto (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebased Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src='../../resources/js-test.js'></script>	2 <script src='../../resources/js-test.js'></script>

3 <div id=foo></div>	3 <div id=foo></div>

4 <script>	4 <script>

5 div = document.getElementById('foo');	5 div = document.getElementById('foo');

6 shouldBe('div.style.minWidth', '""');	6 shouldBe('div.style.minWidth', '""');

7 shouldBe('getComputedStyle(div)["min-width"]', '"0px"');	7 shouldBe('getComputedStyle(div)["min-width"]', '"0px"');

8	8

9 div.style.minWidth = 'auto';

10 div.style.maxWidth = 'auto';

11 shouldBe('div.style.minWidth', '""');

12 shouldBe('div.style.maxWidth', '""');

13 shouldBe('getComputedStyle(div).minWidth', '"0px"');

14

15 div.style.minWidth = 0;	9 div.style.minWidth = 0;

16 shouldBe('div.style.minWidth', '"0px"');	10 shouldBe('div.style.minWidth', '"0px"');

17 shouldBe('getComputedStyle(div)["min-width"]', '"0px"');	11 shouldBe('getComputedStyle(div)["min-width"]', '"0px"');
	Julien - ping for review 2015/04/06 17:06:47 Why was this code moved? It doesn't seem any more Why was this code moved? It doesn't seem any more structured and just adds some unneeded churn. cbiesinger 2015/04/06 21:34:16 Hmm good question. I started out with this patch b Show quoted text On 2015/04/06 17:06:47, Julien - PST CC moar reviewers wrote: > Why was this code moved? It doesn't seem any more structured and just adds some > unneeded churn. Hmm good question. I started out with this patch by reverting the original removal of min-width auto, and this is probably a leftover from that. Anyway, I undid this.
18	12

	13 div.style.minWidth = 'auto';

	14 div.style.maxWidth = 'auto';

	15 shouldBe('div.style.minWidth', '"auto"');

	16 shouldBe('div.style.maxWidth', '""');

	17 shouldBe('getComputedStyle(div).minWidth', '"0px"');

	18

19 shouldBe('div.style.minHeight', '""');	19 shouldBe('div.style.minHeight', '""');

20 shouldBe('getComputedStyle(div)["min-height"]', '"0px"');	20 shouldBe('getComputedStyle(div)["min-height"]', '"0px"');

21	21

22 div.style.minHeight = 'auto';

23 div.style.maxHeight = 'auto';

24 shouldBe('div.style.minHeight', '""');

25 shouldBe('div.style.maxHeight', '""');

26 shouldBe('getComputedStyle(div).minHeight', '"0px"');

27

28 div.style.minHeight = 0;	22 div.style.minHeight = 0;

29 shouldBe('div.style.minHeight', '"0px"');	23 shouldBe('div.style.minHeight', '"0px"');

30 shouldBe('getComputedStyle(div)["min-height"]', '"0px"');	24 shouldBe('getComputedStyle(div)["min-height"]', '"0px"');

31	25

	26 div.style.minHeight = 'auto';

	27 div.style.maxHeight = 'auto';

	28 shouldBe('div.style.minHeight', '"auto"');

	29 shouldBe('div.style.maxHeight', '""');
	Julien - ping for review 2015/04/06 17:06:47 This is surprising as max-height should be 'auto' This is surprising as max-height should be 'auto' too. cbiesinger 2015/04/06 21:34:16 auto is not a valid value for max-height/max-width Show quoted text On 2015/04/06 17:06:47, Julien - PST CC moar reviewers wrote: > This is surprising as max-height should be 'auto' too. auto is not a valid value for max-height/max-width, even with this spec change. See http://dev.w3.org/csswg/css-flexbox/#min-size-auto
	30 shouldBe('getComputedStyle(div).minHeight', '"0px"');

32 </script>	31 </script>

OLD	NEW

« no previous file with comments | « LayoutTests/css3/flexbox/resources/solidblue.png ('k') | LayoutTests/fast/css/auto-min-size-expected.txt » ('j') | Source/core/layout/LayoutBox.h » ('J')