Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 988523003: Reimplement min-width: auto (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index 0329919790cbd0f683b2aa50737901cd1235bf96..0848095e0618e68cd698dd100ddfefeda5763c06 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -824,7 +824,7 @@ bool CSSPropertyParser::parseValue(CSSPropertyID propId, bool important)
// fall through
case CSSPropertyWebkitMinLogicalWidth:
case CSSPropertyWebkitMinLogicalHeight:
- validPrimitive = validWidthOrHeight(value, unitless);
+ validPrimitive = (id == CSSValueAuto || validWidthOrHeight(value, unitless));
Julien - ping for review 2015/04/06 17:06:47 Unneeded parentheses.
cbiesinger 2015/04/06 21:34:16 Yes, but this matches the style in the cases aroun
Julien - ping for review 2015/04/13 21:25:59 This goes against our usual convention. I would ar
cbiesinger 2015/04/13 23:23:12 Hmm ok, removed the parentheses.
break;
case CSSPropertyWidth:

Powered by Google App Engine
This is Rietveld 408576698