Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 988523003: Reimplement min-width: auto (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
9 * Copyright (C) 2012 Intel Corporation. All rights reserved. 9 * Copyright (C) 2012 Intel Corporation. All rights reserved.
10 * 10 *
(...skipping 806 matching lines...) Expand 10 before | Expand all | Expand 10 after
817 case CSSPropertyWebkitMaxLogicalHeight: 817 case CSSPropertyWebkitMaxLogicalHeight:
818 validPrimitive = (id == CSSValueNone || validWidthOrHeight(value, unitle ss)); 818 validPrimitive = (id == CSSValueNone || validWidthOrHeight(value, unitle ss));
819 break; 819 break;
820 820
821 case CSSPropertyMinWidth: 821 case CSSPropertyMinWidth:
822 case CSSPropertyMinHeight: 822 case CSSPropertyMinHeight:
823 unitless = FUnitlessQuirk; 823 unitless = FUnitlessQuirk;
824 // fall through 824 // fall through
825 case CSSPropertyWebkitMinLogicalWidth: 825 case CSSPropertyWebkitMinLogicalWidth:
826 case CSSPropertyWebkitMinLogicalHeight: 826 case CSSPropertyWebkitMinLogicalHeight:
827 validPrimitive = validWidthOrHeight(value, unitless); 827 validPrimitive = (id == CSSValueAuto || validWidthOrHeight(value, unitle ss));
Julien - ping for review 2015/04/06 17:06:47 Unneeded parentheses.
cbiesinger 2015/04/06 21:34:16 Yes, but this matches the style in the cases aroun
Julien - ping for review 2015/04/13 21:25:59 This goes against our usual convention. I would ar
cbiesinger 2015/04/13 23:23:12 Hmm ok, removed the parentheses.
828 break; 828 break;
829 829
830 case CSSPropertyWidth: 830 case CSSPropertyWidth:
831 case CSSPropertyHeight: 831 case CSSPropertyHeight:
832 unitless = FUnitlessQuirk; 832 unitless = FUnitlessQuirk;
833 // fall through 833 // fall through
834 case CSSPropertyWebkitLogicalWidth: 834 case CSSPropertyWebkitLogicalWidth:
835 case CSSPropertyWebkitLogicalHeight: 835 case CSSPropertyWebkitLogicalHeight:
836 validPrimitive = (id == CSSValueAuto || validWidthOrHeight(value, unitle ss)); 836 validPrimitive = (id == CSSValueAuto || validWidthOrHeight(value, unitle ss));
837 break; 837 break;
(...skipping 7634 matching lines...) Expand 10 before | Expand all | Expand 10 after
8472 } 8472 }
8473 } 8473 }
8474 8474
8475 if (!list->length()) 8475 if (!list->length())
8476 return nullptr; 8476 return nullptr;
8477 8477
8478 return list.release(); 8478 return list.release();
8479 } 8479 }
8480 8480
8481 } // namespace blink 8481 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698