Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 988453002: Request uncompressed images from data reduction proxy when saving. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments by avi@. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
index fc76b17d38ab7b64bdcc0e9f4fc62b9689676ed9..e3210020b9d06ee514bd8219c047235b379b755f 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -1310,7 +1310,6 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
if (command_executed_)
return;
command_executed_ = true;
-
Avi (use Gerrit) 2015/03/06 23:55:20 Why drop the space here?
Not at Google. Contact bengr 2015/03/07 00:45:02 Done.
RenderFrameHost* render_frame_host = GetRenderFrameHost();
// Process extension menu items.
@@ -1390,7 +1389,17 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
RecordDownloadSource(DOWNLOAD_INITIATED_BY_CONTEXT_MENU);
const GURL& url = params_.src_url;
content::Referrer referrer = CreateSaveAsReferrer(url, params_);
- source_web_contents_->SaveFrame(url, referrer);
+
+ std::string headers;
+ if (params_.media_type == WebContextMenuData::MediaTypeImage &&
+ !browser_context_->IsOffTheRecord() &&
+ DataReductionProxyChromeSettingsFactory::GetForBrowserContext(
+ browser_context_)->CanUseDataReductionProxy(
+ params_.src_url)) {
+ headers = data_reduction_proxy::kDataReductionPassThroughHeader;
+ }
+
+ source_web_contents_->SaveFrameWithHeaders(url, referrer, headers);
}
break;
}
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl.h » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698