Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 988453002: Request uncompressed images from data reduction proxy when saving. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments by avi@. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index e56e327c7d163be0dddcbfba4fd4a4e2b58f75aa..ec74530933728c374b82422530d9d21855706517 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2302,6 +2302,12 @@ bool WebContentsImpl::SavePage(const base::FilePath& main_file,
void WebContentsImpl::SaveFrame(const GURL& url,
const Referrer& referrer) {
+ SaveFrameWithHeaders(url, referrer, std::string());
+}
+
+void WebContentsImpl::SaveFrameWithHeaders(const GURL& url,
+ const Referrer& referrer,
+ const std::string& headers) {
if (!GetLastCommittedURL().is_valid())
return;
if (delegate_ && delegate_->SaveFrame(url, referrer))
@@ -2325,10 +2331,22 @@ void WebContentsImpl::SaveFrame(const GURL& url,
DownloadUrlParameters::FromWebContents(this, url));
params->set_referrer(referrer);
params->set_post_id(post_id);
- params->set_prefer_cache(true);
if (post_id >= 0)
params->set_method("POST");
params->set_prompt(true);
+
+ if (headers.empty()) {
+ params->set_prefer_cache(true);
+ } else {
+ std::vector<std::string> key_value_list;
+ base::SplitString(headers, '\n', &key_value_list);
+ for (const auto& key_value : key_value_list) {
+ std::vector<std::string> pair;
+ base::SplitString(key_value, ':', &pair);
+ DCHECK_EQ(pair.size(), 2ul);
Avi (use Gerrit) 2015/03/06 23:55:20 Switch parameters; when the DCHECK fails, the erro
Not at Google. Contact bengr 2015/03/07 00:45:02 Done.
+ params->add_request_header(pair[0], pair[1]);
+ }
+ }
dlm->DownloadUrl(params.Pass());
}

Powered by Google App Engine
This is Rietveld 408576698