Change device creation to see the (optional) layer-paint

Change device creation to see the (optional) layer-paint

Motivation:

PDFDevice currently relies on 1) being told that the layer's paint has an imagefilter, and in the case, it creates a rasterdevice. It then relies on (2) canvas itself sniffing the layer's paint and offering to apply-the-imagefilter to call drawSprite instead of drawDevice.

This subtle interchange is fragile, and also does not support other unsupported PDF features like colorfilters. This CL is a step toward making this use-raster-instead-of-native approach to layers more completely in the subclass' hands.

Committed: https://skia.googlesource.com/skia/+/1182d9a96b80bd12183ee7c81325a979a51ee0c0

[reed1, 2015-03-09 18:19:13]

reed@google.com changed reviewers:
+ halcanary@google.com, robertphillips@google.com, senorblanco@google.com

[reed1, 2015-03-09 20:22:44]

PTAL

[reed1, 2015-03-09 20:22:52]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-03-09 20:23:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/988413003/40001

[commit-bot: I haz the power, 2015-03-09 20:23:12]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-03-10 02:23 UTC

[commit-bot: I haz the power, 2015-03-09 20:24:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-09 20:24:26]

Try jobs failed on following builders:
  Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...)

[reed1, 2015-03-09 20:52:19]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-03-09 20:52:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/988413003/60001

[commit-bot: I haz the power, 2015-03-09 20:52:33]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-03-10 02:52 UTC

[hal.canary, 2015-03-09 20:53:18]

PDF: LGTM

https://codereview.chromium.org/988413003/diff/40001/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/988413003/diff/40001/src/pdf/SkPDFDevice.cpp#...
src/pdf/SkPDFDevice.cpp:569: bool not_supported_for_layers(const SkPaint&
layerPaint) {
static bool not_supported_for_layers(

[commit-bot: I haz the power, 2015-03-09 20:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-09 20:54:04]

Try jobs failed on following builders:
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Cl...)

[reed1, 2015-03-09 21:03:10]

https://codereview.chromium.org/988413003/diff/40001/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/988413003/diff/40001/src/pdf/SkPDFDevice.cpp#...
src/pdf/SkPDFDevice.cpp:569: bool not_supported_for_layers(const SkPaint&
layerPaint) {
On 2015/03/09 20:53:18, Hal Canary wrote:
> static bool not_supported_for_layers(

Done.

[reed1, 2015-03-09 21:11:36]

The CQ bit was checked by reed@google.com

[reed1, 2015-03-09 21:11:37]

The patchset sent to the CQ was uploaded after l-g-t-m from halcanary@google.com
Link to the patchset: https://codereview.chromium.org/988413003/#ps100001
(title: "address comment from #8")

[commit-bot: I haz the power, 2015-03-09 21:12:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/988413003/100001

[reed1, 2015-03-09 21:12:21]

The CQ bit was unchecked by reed@google.com

[robertphillips, 2015-03-10 13:49:25]

lgtm modulo the #if'ed out code

https://codereview.chromium.org/988413003/diff/120001/include/core/SkDevice.h
File include/core/SkDevice.h (right):

https://codereview.chromium.org/988413003/diff/120001/include/core/SkDevice.h...
include/core/SkDevice.h:331: 
construct -> constructor ?

https://codereview.chromium.org/988413003/diff/120001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/988413003/diff/120001/src/core/SkCanvas.cpp#n...
src/core/SkCanvas.cpp:897: void SkCanvas::internalSaveLayer(const SkRect*
bounds, const SkPaint* paint, SaveFlags flags,
Can we remove justForImageFilter ?

https://codereview.chromium.org/988413003/diff/120001/src/core/SkCanvas.cpp#n...
src/core/SkCanvas.cpp:936: SkBaseDevice::TileUsage usage =
SkBaseDevice::kNever_TileUsage;
What's up with this #if'ed out code ?

https://codereview.chromium.org/988413003/diff/120001/src/core/SkDevice.cpp
File src/core/SkDevice.cpp (right):

https://codereview.chromium.org/988413003/diff/120001/src/core/SkDevice.cpp#n...
src/core/SkDevice.cpp:72: case kNever_TileUsage:
Did we ever get an answer on why we don't do this for kPossible too?

[reed1, 2015-03-13 14:07:09]

PTAL

https://codereview.chromium.org/988413003/diff/120001/include/core/SkDevice.h
File include/core/SkDevice.h (right):

https://codereview.chromium.org/988413003/diff/120001/include/core/SkDevice.h...
include/core/SkDevice.h:331: 
On 2015/03/10 13:49:25, robertphillips wrote:
> construct -> constructor ?

Done.

https://codereview.chromium.org/988413003/diff/120001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/988413003/diff/120001/src/core/SkCanvas.cpp#n...
src/core/SkCanvas.cpp:897: void SkCanvas::internalSaveLayer(const SkRect*
bounds, const SkPaint* paint, SaveFlags flags,
On 2015/03/10 13:49:25, robertphillips wrote:
> Can we remove justForImageFilter ?

Done.

https://codereview.chromium.org/988413003/diff/120001/src/core/SkCanvas.cpp#n...
src/core/SkCanvas.cpp:936: SkBaseDevice::TileUsage usage =
SkBaseDevice::kNever_TileUsage;
On 2015/03/10 13:49:25, robertphillips wrote:
> What's up with this #if'ed out code ?

Done.

https://codereview.chromium.org/988413003/diff/120001/src/core/SkDevice.cpp
File src/core/SkDevice.cpp (right):

https://codereview.chromium.org/988413003/diff/120001/src/core/SkDevice.cpp#n...
src/core/SkDevice.cpp:72: case kNever_TileUsage:
On 2015/03/10 13:49:25, robertphillips wrote:
> Did we ever get an answer on why we don't do this for kPossible too?

Will add comment.

[reed1, 2015-03-13 14:07:17]

The CQ bit was checked by reed@google.com

[reed1, 2015-03-13 14:07:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
halcanary@google.com, robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/988413003/#ps160001
(title: "address comments")

[commit-bot: I haz the power, 2015-03-13 14:07:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/988413003/160001

[commit-bot: I haz the power, 2015-03-13 14:16:12]

Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/1182d9a96b80bd12183ee7c81325a979a51ee0c0

[reed1, 2015-03-13 14:27:56]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/1008863002/ by reed@google.com.

The reason for reverting is: need to have chrome opt-in for the older API before
this can land (in chrome).

[Stephen White, 2015-03-13 19:34:47]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2015-03-13 19:34:48]

https://codereview.chromium.org/988413003/diff/160001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/988413003/diff/160001/src/core/SkCanvas.cpp#n...
src/core/SkCanvas.cpp:939: // Related to
https://code.google.com/p/skia/issues/detail?id=3519 ?
I don't think so. I think this is related to the use of exact-match vs.
approx-match textures as filter backing stores on the GPU path. Some filters
give incorrect results with approx-match textures. It may be possible to fix the
affected filters through the use of texture coordinate clamping in the shader.

I've logged skbug.com/3532 for this.