Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 988323005: Move setCoveredByChild methods to Tab. (Closed)

Created:
5 years, 9 months ago by Maria
Modified:
5 years, 9 months ago
Reviewers:
gone
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move setCoveredByChild methods to Tab. Moves a subclass Tab method up to superclass to eliminate the dependency on the downstream Tab implementation. Removes the no longer necessary method from TabDelegate. BUG=464934 Committed: https://crrev.com/a0bf8e711f92b7567e6ce3d6faba56825d36c13b Cr-Commit-Position: refs/heads/master@{#319737}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
Maria
5 years, 9 months ago (2015-03-09 20:47:45 UTC) #2
gone
lgtm
5 years, 9 months ago (2015-03-09 20:50:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988323005/1
5 years, 9 months ago (2015-03-09 20:51:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 21:32:17 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 21:33:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0bf8e711f92b7567e6ce3d6faba56825d36c13b
Cr-Commit-Position: refs/heads/master@{#319737}

Powered by Google App Engine
This is Rietveld 408576698