chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java - Issue 988323005: Move setCoveredByChild methods to Tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

Issue 988323005: Move setCoveredByChild methods to Tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/Tab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

index 574047ccda4210d4ac35bfa16f85e8361a99531f..17d35617234d62d0f2af78cba833f12e2f7cd0a4 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

@@ -439,7 +439,7 @@ public class DocumentTabModelImpl extends TabModelJniBridge implements DocumentT

Entry currentEntry = mEntryMap.get(id);

String currentUrl = tab.getUrl();

boolean canGoBack = tab.canGoBack();

- boolean isCoveredByChildActivity = mTabDelegate.isTabCoveredByChildActivity(tab);

+ boolean isCoveredByChildActivity = tab.isCoveredByChildActivity();

TabState state = tab.getState();

if (currentEntry != null

&& currentEntry.tabId == id