build/common.gypi - Issue 988243002: Disable failing ODR detection for Valgrind as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 988243002: Disable failing ODR detection for Valgrind as well. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index fd2fc1a27f7bb20afbcd70d6f3005e8589444e64..4bd04a62f77c596b57c8f65e2804acf519c71190 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -4492,7 +4492,7 @@

'conditions': [

# TODO(thestig): Enable this for disabled cases.

- [ 'buildtype!="Official" and chromeos==0 and asan==0 and lsan==0 and tsan==0 and msan==0 and ubsan==0 and ubsan_vptr==0', {

+ [ 'buildtype!="Official" and chromeos==0 and release_valgrind_build==1 and asan==0 and lsan==0 and tsan==0 and msan==0 and ubsan==0 and ubsan_vptr==0', {

Nico 2015/03/09 03:25:38 != 1 though?

'ldflags': [

'-Wl,--detect-odr-violations',

« no previous file with comments | « no previous file | no next file » | no next file with comments »