Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Side by Side Diff: build/common.gypi

Issue 988243002: Disable failing ODR detection for Valgrind as well. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 4474 matching lines...) Expand 10 before | Expand all | Expand 10 after
4485 # https://groups.google.com/a/chromium.org/group/chromium-dev/ browse_thread/thread/281527606915bb36 4485 # https://groups.google.com/a/chromium.org/group/chromium-dev/ browse_thread/thread/281527606915bb36
4486 # Only apply this to the target linker, since the host 4486 # Only apply this to the target linker, since the host
4487 # linker might not be gold, but isn't used much anyway. 4487 # linker might not be gold, but isn't used much anyway.
4488 # TODO(raymes): Disable threading because gold is frequently 4488 # TODO(raymes): Disable threading because gold is frequently
4489 # crashing on the bots: crbug.com/161942. 4489 # crashing on the bots: crbug.com/161942.
4490 # '-Wl,--threads', 4490 # '-Wl,--threads',
4491 # '-Wl,--thread-count=4', 4491 # '-Wl,--thread-count=4',
4492 ], 4492 ],
4493 'conditions': [ 4493 'conditions': [
4494 # TODO(thestig): Enable this for disabled cases. 4494 # TODO(thestig): Enable this for disabled cases.
4495 [ 'buildtype!="Official" and chromeos==0 and asan==0 and lsan= =0 and tsan==0 and msan==0 and ubsan==0 and ubsan_vptr==0', { 4495 [ 'buildtype!="Official" and chromeos==0 and release_valgrind_ build==1 and asan==0 and lsan==0 and tsan==0 and msan==0 and ubsan==0 and ubsan_ vptr==0', {
Nico 2015/03/09 03:25:38 != 1 though?
4496 'ldflags': [ 4496 'ldflags': [
4497 '-Wl,--detect-odr-violations', 4497 '-Wl,--detect-odr-violations',
4498 ], 4498 ],
4499 }], 4499 }],
4500 ], 4500 ],
4501 }], 4501 }],
4502 ], 4502 ],
4503 'conditions': [ 4503 'conditions': [
4504 ['release_valgrind_build==0 and order_profiling==0', { 4504 ['release_valgrind_build==0 and order_profiling==0', {
4505 'target_conditions': [ 4505 'target_conditions': [
(...skipping 1535 matching lines...) Expand 10 before | Expand all | Expand 10 after
6041 # settings in target dicts. SYMROOT is a special case, because many other 6041 # settings in target dicts. SYMROOT is a special case, because many other
6042 # Xcode variables depend on it, including variables such as 6042 # Xcode variables depend on it, including variables such as
6043 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6043 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6044 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6044 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6045 # files to appear (when present) in the UI as actual files and not red 6045 # files to appear (when present) in the UI as actual files and not red
6046 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6046 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6047 # and therefore SYMROOT, needs to be set at the project level. 6047 # and therefore SYMROOT, needs to be set at the project level.
6048 'SYMROOT': '<(DEPTH)/xcodebuild', 6048 'SYMROOT': '<(DEPTH)/xcodebuild',
6049 }, 6049 },
6050 } 6050 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698