Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 988243002: Disable failing ODR detection for Valgrind as well. (Closed)

Created:
5 years, 9 months ago by Lei Zhang
Modified:
5 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
Lei Zhang
TBR
5 years, 9 months ago (2015-03-09 03:24:53 UTC) #1
Nico
TB lgtm
5 years, 9 months ago (2015-03-09 03:25:11 UTC) #2
Nico
https://codereview.chromium.org/988243002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/988243002/diff/1/build/common.gypi#newcode4495 build/common.gypi:4495: [ 'buildtype!="Official" and chromeos==0 and release_valgrind_build==1 and asan==0 and ...
5 years, 9 months ago (2015-03-09 03:25:38 UTC) #3
Lei Zhang
Yep, patch set 2.
5 years, 9 months ago (2015-03-09 03:26:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988243002/20001
5 years, 9 months ago (2015-03-09 03:27:00 UTC) #7
Nico
patch set 2 lgtm
5 years, 9 months ago (2015-03-09 03:30:02 UTC) #8
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 05:30:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988243002/20001
5 years, 9 months ago (2015-03-09 05:35:30 UTC) #13
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 05:36:05 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/70d2521d044f34dce21cbcc754c1ef99226e53c2 Cr-Commit-Position: refs/heads/master@{#319599}
5 years, 9 months ago (2015-03-09 05:39:22 UTC) #17
Lei Zhang
5 years, 9 months ago (2015-03-09 05:39:34 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
70d2521d044f34dce21cbcc754c1ef99226e53c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698