Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 988173002: Sync HTML element interfaces C-D with the spec (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
vivekg, Jens Widell
CC:
arv+blink, blink-reviews, blink-reviews-html_chromium.org, Inactive, dglazkov+blink, vivekg_samsung
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync HTML element interfaces C-D with the spec There are no changes to the generated code except ordering. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191547

Patch Set 1 #

Total comments: 8

Patch Set 2 : turn FIXME into Note #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
M Source/core/html/HTMLCanvasElement.idl View 1 2 chunks +10 lines, -3 lines 0 comments Download
M Source/core/html/HTMLContentElement.idl View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/html/HTMLDListElement.idl View 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/html/HTMLDataListElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLDialogElement.idl View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/html/HTMLDirectoryElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLDivElement.idl View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (4 generated)
philipj_slow
PTAL
5 years, 9 months ago (2015-03-08 09:28:18 UTC) #2
philipj_slow
A-B is in https://codereview.chromium.org/991513002/ if you want to take a look.
5 years, 9 months ago (2015-03-08 09:28:40 UTC) #3
Jens Widell
https://codereview.chromium.org/988173002/diff/1/Source/core/html/HTMLCanvasElement.idl File Source/core/html/HTMLCanvasElement.idl (right): https://codereview.chromium.org/988173002/diff/1/Source/core/html/HTMLCanvasElement.idl#newcode52 Source/core/html/HTMLCanvasElement.idl:52: // trailing arguments should be variadic. The variadic bit ...
5 years, 9 months ago (2015-03-08 09:36:46 UTC) #4
Jens Widell
5 years, 9 months ago (2015-03-08 09:36:48 UTC) #5
vivekg
lgtm with following comment. But that could be taken up separately on blink-dev may be. ...
5 years, 9 months ago (2015-03-08 09:46:42 UTC) #7
vivekg
https://codereview.chromium.org/988173002/diff/1/Source/core/html/HTMLDivElement.idl File Source/core/html/HTMLDivElement.idl (right): https://codereview.chromium.org/988173002/diff/1/Source/core/html/HTMLDivElement.idl#newcode25 Source/core/html/HTMLDivElement.idl:25: [Reflect] attribute DOMString align; On 2015/03/08 at 09:46:41, vivekg_ ...
5 years, 9 months ago (2015-03-08 09:48:52 UTC) #8
philipj_slow
https://codereview.chromium.org/988173002/diff/1/Source/core/html/HTMLCanvasElement.idl File Source/core/html/HTMLCanvasElement.idl (right): https://codereview.chromium.org/988173002/diff/1/Source/core/html/HTMLCanvasElement.idl#newcode52 Source/core/html/HTMLCanvasElement.idl:52: // trailing arguments should be variadic. On 2015/03/08 09:36:46, ...
5 years, 9 months ago (2015-03-08 14:28:58 UTC) #9
Jens Widell
https://codereview.chromium.org/988173002/diff/1/Source/core/html/HTMLCanvasElement.idl File Source/core/html/HTMLCanvasElement.idl (right): https://codereview.chromium.org/988173002/diff/1/Source/core/html/HTMLCanvasElement.idl#newcode52 Source/core/html/HTMLCanvasElement.idl:52: // trailing arguments should be variadic. On 2015/03/08 14:28:58, ...
5 years, 9 months ago (2015-03-08 15:56:28 UTC) #10
philipj_slow
turn FIXME into Note
5 years, 9 months ago (2015-03-09 10:42:45 UTC) #11
philipj_slow
https://codereview.chromium.org/988173002/diff/1/Source/core/html/HTMLCanvasElement.idl File Source/core/html/HTMLCanvasElement.idl (right): https://codereview.chromium.org/988173002/diff/1/Source/core/html/HTMLCanvasElement.idl#newcode52 Source/core/html/HTMLCanvasElement.idl:52: // trailing arguments should be variadic. On 2015/03/08 15:56:28, ...
5 years, 9 months ago (2015-03-09 10:43:25 UTC) #12
Jens Widell
LGTM
5 years, 9 months ago (2015-03-09 10:53:16 UTC) #13
philipj_slow
https://codereview.chromium.org/988173002/diff/1/Source/core/html/HTMLDivElement.idl File Source/core/html/HTMLDivElement.idl (right): https://codereview.chromium.org/988173002/diff/1/Source/core/html/HTMLDivElement.idl#newcode25 Source/core/html/HTMLDivElement.idl:25: [Reflect] attribute DOMString align; On 2015/03/08 14:28:58, philipj_UTC7 wrote: ...
5 years, 9 months ago (2015-03-09 11:20:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988173002/20001
5 years, 9 months ago (2015-03-09 11:20:55 UTC) #17
Jens Widell
On 2015/03/09 11:20:08, philipj_UTC7 wrote: > https://codereview.chromium.org/988173002/diff/1/Source/core/html/HTMLDivElement.idl > File Source/core/html/HTMLDivElement.idl (right): > > https://codereview.chromium.org/988173002/diff/1/Source/core/html/HTMLDivElement.idl#newcode25 > ...
5 years, 9 months ago (2015-03-09 11:27:25 UTC) #18
vivekg
On 2015/03/09 11:27:25, Jens Widell wrote: > On 2015/03/09 11:20:08, philipj_UTC7 wrote: > > > ...
5 years, 9 months ago (2015-03-09 12:24:01 UTC) #19
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 14:03:11 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191547

Powered by Google App Engine
This is Rietveld 408576698