Source/core/html/HTMLDivElement.idl - Issue 988173002: Sync HTML element interfaces C-D with the spec

Side by Side Diff: Source/core/html/HTMLDivElement.idl

Issue 988173002: Sync HTML element interfaces C-D with the spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/core/html/HTMLCanvasElement.idl ('K') | « Source/core/html/HTMLDirectoryElement.idl ('k') | no next file » | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2010 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2010 Apple Inc. All rights reserved.

3 *	3 *

4 * This library is free software; you can redistribute it and/or	4 * This library is free software; you can redistribute it and/or

5 * modify it under the terms of the GNU Library General Public	5 * modify it under the terms of the GNU Library General Public

6 * License as published by the Free Software Foundation; either	6 * License as published by the Free Software Foundation; either

7 * version 2 of the License, or (at your option) any later version.	7 * version 2 of the License, or (at your option) any later version.

8 *	8 *

9 * This library is distributed in the hope that it will be useful,	9 * This library is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU	11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU

12 * Library General Public License for more details.	12 * Library General Public License for more details.

13 *	13 *

14 * You should have received a copy of the GNU Library General Public License	14 * You should have received a copy of the GNU Library General Public License

15 * along with this library; see the file COPYING.LIB. If not, write to	15 * along with this library; see the file COPYING.LIB. If not, write to

16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,	16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,

17 * Boston, MA 02110-1301, USA.	17 * Boston, MA 02110-1301, USA.

18 */	18 */

19	19

	20 // https://html.spec.whatwg.org/#htmldivelement

	21

20 interface HTMLDivElement : HTMLElement {	22 interface HTMLDivElement : HTMLElement {

	23 // obsolete members

	24 // https://html.spec.whatwg.org/#HTMLDivElement-partial

21 [Reflect] attribute DOMString align;	25 [Reflect] attribute DOMString align;
	vivekg 2015/03/08 09:46:41 The inline comments like 'obsolete members' might The inline comments like 'obsolete members' might go out-of-place in subsequent changes and might become irrelevant soonish in a given context. How about adding an extended attribute to the IDL like: [Reflect, Obsolete] attribute DOMString align; This way each attribute/method is properly accounted for being obsolete and if required, this could be further used to warn the web developers about the deprecation. Also if there exist an alternate way to achieve the same, we could also consider using 'UseAlternative=XYZ'. WDYT? vivekg 2015/03/08 09:48:52 We could possible reuse 'ImplementedAs=' here as w Show quoted text On 2015/03/08 at 09:46:41, vivekg_ wrote: > > Also if there exist an alternate way to achieve the same, we could also consider using 'UseAlternative=XYZ'. > We could possible reuse 'ImplementedAs=' here as well instead of inventing a new one. philipj_slow 2015/03/08 14:28:58 These are the things listed separately in the HTML Show quoted text On 2015/03/08 09:46:41, vivekg_ wrote: > The inline comments like 'obsolete members' might go out-of-place in subsequent > changes and might become irrelevant soonish in a given context. > How about adding an extended attribute to the IDL like: > > [Reflect, Obsolete] attribute DOMString align; > > This way each attribute/method is properly accounted for being obsolete and > if required, this could be further used to warn the web developers about the > deprecation. > > Also if there exist an alternate way to achieve the same, we could also consider > using 'UseAlternative=XYZ'. > > WDYT? These are the things listed separately in the HTML spec with a link "also has obsolete members" from the main interface definition. They're not deprecated or likely to be removed. I actually kind of wish the HTML spec didn't bother splitting the interfaces, since these things aren't actually going to be removed. Is there some clarifying comment I could add to avoid the impression that these should be deprecated removed? philipj_slow 2015/03/09 11:20:07 I'm going to land this CL as-is, but if you have s Show quoted text On 2015/03/08 14:28:58, philipj_UTC7 wrote: > On 2015/03/08 09:46:41, vivekg_ wrote: > > The inline comments like 'obsolete members' might go out-of-place in > subsequent > > changes and might become irrelevant soonish in a given context. > > How about adding an extended attribute to the IDL like: > > > > [Reflect, Obsolete] attribute DOMString align; > > > > This way each attribute/method is properly accounted for being obsolete and > > if required, this could be further used to warn the web developers about the > > deprecation. > > > > Also if there exist an alternate way to achieve the same, we could also > consider > > using 'UseAlternative=XYZ'. > > > > WDYT? > > These are the things listed separately in the HTML spec with a link "also has > obsolete members" from the main interface definition. They're not deprecated or > likely to be removed. > > I actually kind of wish the HTML spec didn't bother splitting the interfaces, > since these things aren't actually going to be removed. > > Is there some clarifying comment I could add to avoid the impression that these > should be deprecated removed? I'm going to land this CL as-is, but if you have suggestions here just say so and I'll fix this and all of the other instances landed in other CLs.
22 };	26 };

OLD	NEW