Source/web/WebLocalFrameImpl.h - Issue 988023005: Implementing directional selection strategy in Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.h

Issue 988023005: Implementing directional selection strategy in Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressing feedback. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebLocalFrameImpl.h

diff --git a/Source/web/WebLocalFrameImpl.h b/Source/web/WebLocalFrameImpl.h

index 1e047f62171f337efa1bb8e74b6345088e70e151..15623ca9cdf6bd444efd46ce3bf6393177e651aa 100644

--- a/Source/web/WebLocalFrameImpl.h

+++ b/Source/web/WebLocalFrameImpl.h

@@ -172,7 +172,7 @@ public:

virtual bool selectWordAroundCaret() override;

virtual void selectRange(const WebPoint& base, const WebPoint& extent) override;

virtual void selectRange(const WebRange&) override;

- virtual void moveRangeSelectionExtent(const WebPoint&, WebFrame::TextGranularity = CharacterGranularity) override;

+ virtual void moveRangeSelectionExtent(const WebPoint&) override;

virtual void moveRangeSelection(const WebPoint& base, const WebPoint& extent, WebFrame::TextGranularity = CharacterGranularity) override;

virtual void moveCaretSelection(const WebPoint&) override;

virtual bool setEditableSelectionOffsets(int start, int end) override;

« Source/core/editing/VisibleSelection.cpp ('K') | « Source/core/frame/Settings.in ('k') | Source/web/WebLocalFrameImpl.cpp » ('j') | public/web/WebLocalFrame.h » ('J')