public/web/WebLocalFrame.h - Issue 988023005: Implementing directional selection strategy in Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebLocalFrame.h

Issue 988023005: Implementing directional selection strategy in Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressing feedback. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebLocalFrame.h

diff --git a/public/web/WebLocalFrame.h b/public/web/WebLocalFrame.h

index 72be9be027a3d3374333f3127deeb89687edc365..e085e05dde55b8e7f00c82b55a7c59695ec05d0e 100644

--- a/public/web/WebLocalFrame.h

+++ b/public/web/WebLocalFrame.h

@@ -120,7 +120,7 @@ public:

// Moves the selection extent point. This function does not allow the

// selection to collapse. If the new extent is set to the same position as

// the current base, this function will do nothing.

- virtual void moveRangeSelectionExtent(const WebPoint&, TextGranularity = CharacterGranularity) = 0;

Rick Byers 2015/04/16 19:09:48 Are there already no callers in chromium that supp

mfomitchev1 2015/04/16 19:33:00 Nope. This parameter was just added by yoichio rec

Rick Byers 2015/04/16 19:35:10 Acknowledged.

+ virtual void moveRangeSelectionExtent(const WebPoint&) = 0;

// Content Settings -------------------------------------------------------

« Source/core/editing/VisibleSelection.cpp ('K') | « Source/web/WebSettingsImpl.cpp ('k') | public/web/WebSettings.h » ('j') | public/web/WebSettings.h » ('J')