DevTools: pick sw targets to attach to on the backend side.

content/browser/devtools/worker_devtools_agent_host.cc

Index: content/browser/devtools/worker_devtools_agent_host.cc
diff --git a/content/browser/devtools/worker_devtools_agent_host.cc b/content/browser/devtools/worker_devtools_agent_host.cc
index 882ed378f2dbeb73660f9cad7ab948c0c8795177..45c3913ae207a5938378ee4e74023f3402f86c23 100644
--- a/content/browser/devtools/worker_devtools_agent_host.cc
+++ b/content/browser/devtools/worker_devtools_agent_host.cc
@@ -65,11 +65,16 @@ bool WorkerDevToolsAgentHost::OnMessageReceived(
   return handled;
 }
 
+void WorkerDevToolsAgentHost::PauseForDebugOnStart() {
+  state_ = WORKER_PAUSED_FOR_DEBUG_ON_START;

[dgozman, 2015/03/08 07:49:56]

DCHECK that state is WORKER_TERMINATED or WORKER_UNINSPECTED.

[pfeldman, 2015/03/08 08:30:57]

In fact, only UNINSPECTED.

+}
+
+bool WorkerDevToolsAgentHost::IsPausedForDebugOnStart() {
+  return state_ == WORKER_PAUSED_FOR_DEBUG_ON_START;
+}
+
 void WorkerDevToolsAgentHost::WorkerReadyForInspection() {
-  if (state_ == WORKER_PAUSED_FOR_DEBUG_ON_START) {
-    RenderProcessHost* rph = RenderProcessHost::FromID(worker_id_.first);
-    Inspect(rph->GetBrowserContext());

[dgozman, 2015/03/08 07:49:56]

This seems to regress shared workers.

[pfeldman, 2015/03/08 08:30:57]

This code only works for ServiceWorkers.

-  } else if (state_ == WORKER_PAUSED_FOR_REATTACH) {
+  if (state_ == WORKER_PAUSED_FOR_REATTACH) {
     DCHECK(IsAttached());

[pfeldman, 2015/03/08 08:30:57]

This code only works for SharedWorkers.

We only "reattach" to shared workers,
We only "debug on start" service workers

That's why I am splitting them into different hosts as a follow up. Having said
that, I think that we need to align Shared to mimic Service behavior long term.

     state_ = WORKER_INSPECTED;
     AttachToWorker();