DevTools: pick sw targets to attach to on the backend side.

content/browser/devtools/worker_devtools_agent_host.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/worker_devtools_agent_host.h"
 
 #include "content/browser/devtools/ipc_devtools_agent_host.h"
 #include "content/browser/devtools/protocol/devtools_protocol_handler.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
@@ skipping 47 matching lines @@
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(WorkerDevToolsAgentHost, msg)
   IPC_MESSAGE_HANDLER(DevToolsClientMsg_DispatchOnInspectorFrontend,
                       OnDispatchOnInspectorFrontend)
   IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
+void WorkerDevToolsAgentHost::PauseForDebugOnStart() {
+  state_ = WORKER_PAUSED_FOR_DEBUG_ON_START;

[dgozman, 2015/03/08 07:49:56]

DCHECK that state is WORKER_TERMINATED or WORKER_UNINSPECTED.

[pfeldman, 2015/03/08 08:30:57]

In fact, only UNINSPECTED.

+}
+
+bool WorkerDevToolsAgentHost::IsPausedForDebugOnStart() {
+  return state_ == WORKER_PAUSED_FOR_DEBUG_ON_START;
+}
+
 void WorkerDevToolsAgentHost::WorkerReadyForInspection() {
-  if (state_ == WORKER_PAUSED_FOR_DEBUG_ON_START) {
-    RenderProcessHost* rph = RenderProcessHost::FromID(worker_id_.first);
-    Inspect(rph->GetBrowserContext());

[dgozman, 2015/03/08 07:49:56]

This seems to regress shared workers.

[pfeldman, 2015/03/08 08:30:57]

This code only works for ServiceWorkers.

-  } else if (state_ == WORKER_PAUSED_FOR_REATTACH) {
+  if (state_ == WORKER_PAUSED_FOR_REATTACH) {
     DCHECK(IsAttached());

[pfeldman, 2015/03/08 08:30:57]

This code only works for SharedWorkers.

We only "reattach" to shared workers,
We only "debug on start" service workers

That's why I am splitting them into different hosts as a follow up. Having said
that, I think that we need to align Shared to mimic Service behavior long term.

     state_ = WORKER_INSPECTED;
     AttachToWorker();
     Reattach();
   }
 }
 
 void WorkerDevToolsAgentHost::WorkerRestarted(WorkerId worker_id) {
   DCHECK_EQ(WORKER_TERMINATED, state_);
   state_ = IsAttached() ? WORKER_PAUSED_FOR_REATTACH : WORKER_UNINSPECTED;
   worker_id_ = worker_id;
@@ skipping 48 matching lines @@
 
 void WorkerDevToolsAgentHost::OnDispatchOnInspectorFrontend(
     const DevToolsMessageChunk& message) {
   if (!IsAttached())
     return;
 
   ProcessChunkedMessageFromAgent(message);
 }
 
 }  // namespace content