Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 98793002: Get rid of extra NULL check when indexing CSSStyleDeclaration (Closed)

Created:
7 years ago by davve
Modified:
7 years ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Get rid of extra NULL check when indexing CSSStyleDeclaration In order to minimize the performance impact of added UseCounters in https://codereview.chromium.org/47923015, remove one superfluous NULL check. We always NULL check propInfo before use anyway. BUG=313864 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp View 5 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
davve
Part of an effort to make PerformanceTests/CSS/CSSPropertyUpdateValue.html less affected by added use counters (in https://codereview.chromium.org/47923015/). ...
7 years ago (2013-12-02 10:26:36 UTC) #1
davve
On 2013/12/02 10:26:36, David Vest wrote: > Before: > > avg 10173.585771733664 runs/s > median ...
7 years ago (2013-12-02 10:30:31 UTC) #2
jochen (gone - plz use gerrit)
lgtm
7 years ago (2013-12-02 10:47:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/98793002/1
7 years ago (2013-12-02 10:53:47 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-02 11:56:27 UTC) #5
Message was sent while issue was closed.
Change committed as 162983

Powered by Google App Engine
This is Rietveld 408576698