Issue 47923015: Add UseCounters for certain properties on CSSStyleDeclaration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 47923015: Add UseCounters for certain properties on CSSStyleDeclaration (Closed)

Created:
7 years, 1 month ago by davve

Modified:
7 years, 1 month ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive, philipj_slow

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add UseCounters for certain properties on CSSStyleDeclaration Blink/WebKit/IE supports properties on CSSStyleDeclaration that are the literal names of the CSS properties, for instance style['font-face']. This is not supported in Gecko/Presto. To measure usage on the Web, introduce two counters: one for the dashed properties and one for the non-'css'-prefixed 'float' property which hasn't been part of the specification. BUG=290055 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160934

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -7 lines)			Patch
	M	Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp	View		3 chunks	+25 lines, -7 lines	0 comments	Download
	M	Source/core/page/UseCounter.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

davve

See comment from zcorpan (<https://code.google.com/p/chromium/issues/detail?id=290055#c4>) as to why we add two flags.

7 years, 1 month ago (2013-10-30 13:00:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/47923015/1

7 years, 1 month ago (2013-10-30 13:13:01 UTC) #3

Message was sent while issue was closed.

Change committed as 160934

Expand Messages | Collapse Messages