Make HTMLOptionsCollection report TypeErrors.

Make HTMLOptionsCollection report TypeErrors.

Switch exceptions to throw TypeError instead of TypeMismatchError when
handling incorrectly typed values over HTMLOptionsCollection methods
and accessors. This aligns behavior with WebIDL, Gecko and Trident.

(Change also includes a drive-by fix to the TextTrackCue constructor
error message.)

R=mkwst
BUG=270033
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162988

[sof, 2013-12-02 11:13:02]

"Modernize" some exceptions reported; at your leisure, please take a look.

[Mike West, 2013-12-02 11:18:12]

LGTM.

https://codereview.chromium.org/98783003/diff/1/Source/bindings/v8/custom/V8T...
File Source/bindings/v8/custom/V8TextTrackCueCustom.cpp (left):

https://codereview.chromium.org/98783003/diff/1/Source/bindings/v8/custom/V8T...
Source/bindings/v8/custom/V8TextTrackCueCustom.cpp:48:
throwTypeError(ExceptionMessages::failedToExecute("Constructor", "TextTrackCue",
ExceptionMessages::notEnoughArguments(3, info.Length())), info.GetIsolate());
This needs a test (which is the worst part of updating error messages... :( ).
Feel free to split that out into a separate CL.

https://codereview.chromium.org/98783003/diff/1/Source/core/html/HTMLOptionsC...
File Source/core/html/HTMLOptionsCollection.cpp (right):

https://codereview.chromium.org/98783003/diff/1/Source/core/html/HTMLOptionsC...
Source/core/html/HTMLOptionsCollection.cpp:128:
exceptionState.throwTypeError(ExceptionMessages::failedToSet(String::number(index),
"HTMLOptionsCollection", "The element provided was not an HTMLOptionElement."));
We'll take care of this one in Bindings, I suppose?

[sof, 2013-12-02 11:21:55]

https://codereview.chromium.org/98783003/diff/1/Source/core/html/HTMLOptionsC...
File Source/core/html/HTMLOptionsCollection.cpp (right):

https://codereview.chromium.org/98783003/diff/1/Source/core/html/HTMLOptionsC...
Source/core/html/HTMLOptionsCollection.cpp:128:
exceptionState.throwTypeError(ExceptionMessages::failedToSet(String::number(index),
"HTMLOptionsCollection", "The element provided was not an HTMLOptionElement."));
On 2013/12/02 11:18:13, Mike West wrote:
> We'll take care of this one in Bindings, I suppose?

Yes, once the generated indexedPropertySetter() passes in an extended
ExceptionState this can be dropped.

[sof, 2013-12-02 11:47:57]

https://codereview.chromium.org/98783003/diff/1/Source/bindings/v8/custom/V8T...
File Source/bindings/v8/custom/V8TextTrackCueCustom.cpp (left):

https://codereview.chromium.org/98783003/diff/1/Source/bindings/v8/custom/V8T...
Source/bindings/v8/custom/V8TextTrackCueCustom.cpp:48:
throwTypeError(ExceptionMessages::failedToExecute("Constructor", "TextTrackCue",
ExceptionMessages::notEnoughArguments(3, info.Length())), info.GetIsolate());
On 2013/12/02 11:18:13, Mike West wrote:
> This needs a test (which is the worst part of updating error messages... :( ).
> Feel free to split that out into a separate CL.

Done.

[Mike West, 2013-12-02 12:01:34]

LGTM again, thanks.

[commit-bot: I haz the power, 2013-12-02 12:02:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/98783003/20001

[commit-bot: I haz the power, 2013-12-02 13:50:34]

Change committed as 162988