Source/bindings/v8/custom/V8TextTrackCueCustom.cpp - Issue 98783003: Make HTMLOptionsCollection report TypeErrors.

Side by Side Diff: Source/bindings/v8/custom/V8TextTrackCueCustom.cpp

Issue 98783003: Make HTMLOptionsCollection report TypeErrors. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add TextTrackCue() exception handling test Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp ('k') | Source/core/html/HTMLOptionsCollection.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2013, Opera Software ASA. All rights reserved.	2 * Copyright (c) 2013, Opera Software ASA. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 27 matching lines...) Expand all Loading...
38 v8::Handle<v8::Value> toV8(TextTrackCue* impl, v8::Handle<v8::Object> creationCo ntext, v8::Isolate* isolate)	38 v8::Handle<v8::Value> toV8(TextTrackCue* impl, v8::Handle<v8::Object> creationCo ntext, v8::Isolate* isolate)

39 {	39 {

40 return toV8(toVTTCue(impl), creationContext, isolate);	40 return toV8(toVTTCue(impl), creationContext, isolate);

41 }	41 }

42	42

43 // Custom constructor to make new TextTrackCue(...) return a VTTCue. This is leg acy	43 // Custom constructor to make new TextTrackCue(...) return a VTTCue. This is leg acy

44 // compat, not per spec, and should be removed at the earliest opportunity.	44 // compat, not per spec, and should be removed at the earliest opportunity.

45 void V8TextTrackCue::constructorCustom(const v8::FunctionCallbackInfo<v8::Value> & info)	45 void V8TextTrackCue::constructorCustom(const v8::FunctionCallbackInfo<v8::Value> & info)

46 {	46 {

47 if (UNLIKELY(info.Length() < 3)) {	47 if (UNLIKELY(info.Length() < 3)) {

48 throwTypeError(ExceptionMessages::failedToExecute("Constructor", "TextTr ackCue", ExceptionMessages::notEnoughArguments(3, info.Length())), info.GetIsola te());	48 throwTypeError(ExceptionMessages::failedToConstruct("TextTrackCue", Exce ptionMessages::notEnoughArguments(3, info.Length())), info.GetIsolate());

49 return;	49 return;

50 }	50 }

51 V8TRYCATCH_VOID(double, startTime, static_cast<double>(info[0]->NumberValue( )));	51 V8TRYCATCH_VOID(double, startTime, static_cast<double>(info[0]->NumberValue( )));

52 V8TRYCATCH_VOID(double, endTime, static_cast<double>(info[1]->NumberValue()) );	52 V8TRYCATCH_VOID(double, endTime, static_cast<double>(info[1]->NumberValue()) );

53 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, text, info[2]);	53 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, text, info[2]);

54	54

55 Document& document = *toDocument(getExecutionContext());	55 Document& document = *toDocument(getExecutionContext());

56 UseCounter::count(document, UseCounter::TextTrackCueConstructor);	56 UseCounter::count(document, UseCounter::TextTrackCueConstructor);

57 VTTCue* impl = VTTCue::create(document, startTime, endTime, text).leakRef();	57 VTTCue* impl = VTTCue::create(document, startTime, endTime, text).leakRef();

58 v8::Handle<v8::Object> wrapper = wrap(impl, info.Holder(), info.GetIsolate() );	58 v8::Handle<v8::Object> wrapper = wrap(impl, info.Holder(), info.GetIsolate() );

59 info.GetReturnValue().Set(wrapper);	59 info.GetReturnValue().Set(wrapper);

60 }	60 }

61	61

62 } // namespace WebCore	62 } // namespace WebCore

OLD	NEW