Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 987693004: Mac 10.6 SDK compatibility (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org, scottmg
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Mac 10.6 SDK compatibility. A couple of the problems related to not having a C++11 library: - You can’t put const elements into a std::vector<>, so CrashReportDatabase::GetPendingReports() and CrashReportDatabase::GetCompletedReports() need to change. There was no data-safety benefit to const elements. - std::string::pop_back() does not exist, another mechanism must be used to trim strings in BreakpadHTTPFormParametersFromMinidump(). One relates to a feature that does not exist in 10.6: - The O_CLOEXEC flag to open() was introduced in 10.7. Although it would be possible to use fcntl(..., F_SETFD, FD_CLOEXEC) on 10.6, the O_CLOEXEC behavior is just removed from CrashReportDatabaseMac::ObtainReportLock(), in line with other open() calls in Crashpad. And one was a real bug: - #define __STDC_FORMAT_MACROS before #including <inttypes.h> to get format macros like SCNx32, used in UUID::InitializeFromString(). TEST=* (gyp_crashpad.py -Dmac_sdk=10.6 -Dmac_deployment_target=10.6) R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/79177046d33a7e5a7da776631a8bf14261d29804

Patch Set 1 #

Patch Set 2 : Define __STDC_FORMAT_MACROS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -27 lines) Patch
M client/crash_report_database.h View 2 chunks +2 lines, -4 lines 0 comments Download
M client/crash_report_database_mac.mm View 5 chunks +7 lines, -9 lines 0 comments Download
M client/crash_report_database_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M client/crash_report_database_win.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M handler/mac/crash_report_upload_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M util/misc/uuid.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-06 19:59:53 UTC) #2
Robert Sesek
LGTM
5 years, 9 months ago (2015-03-06 21:10:12 UTC) #3
Mark Mentovai
5 years, 9 months ago (2015-03-06 23:43:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
79177046d33a7e5a7da776631a8bf14261d29804 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698