Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: client/crash_report_database_win.cc

Issue 987693004: Mac 10.6 SDK compatibility (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Define __STDC_FORMAT_MACROS Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/crash_report_database_test.cc ('k') | handler/mac/crash_report_upload_thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/crash_report_database_win.cc
diff --git a/client/crash_report_database_win.cc b/client/crash_report_database_win.cc
index 630adb1036574dd6762d5987c282faab03357d10..d0d0f2f8a9def2eb313d50a884e8192081fde979 100644
--- a/client/crash_report_database_win.cc
+++ b/client/crash_report_database_win.cc
@@ -209,7 +209,7 @@ class Metadata {
//! \param[out] reports Matching reports, must be empty on entry.
OperationStatus FindReports(
ReportState desired_state,
- std::vector<const CrashReportDatabase::Report>* reports) const;
+ std::vector<CrashReportDatabase::Report>* reports) const;
//! \brief Finds the report matching the given UUID.
//!
@@ -314,7 +314,7 @@ void Metadata::AddNewRecord(const ReportDisk& new_report_disk) {
OperationStatus Metadata::FindReports(
ReportState desired_state,
- std::vector<const CrashReportDatabase::Report>* reports) const {
+ std::vector<CrashReportDatabase::Report>* reports) const {
DCHECK(reports->empty());
for (const auto& report : reports_) {
if (report.state == desired_state &&
@@ -529,10 +529,8 @@ class CrashReportDatabaseWin : public CrashReportDatabase {
UUID* uuid) override;
OperationStatus ErrorWritingCrashReport(NewReport* report) override;
OperationStatus LookUpCrashReport(const UUID& uuid, Report* report) override;
- OperationStatus GetPendingReports(
- std::vector<const Report>* reports) override;
- OperationStatus GetCompletedReports(
- std::vector<const Report>* reports) override;
+ OperationStatus GetPendingReports(std::vector<Report>* reports) override;
+ OperationStatus GetCompletedReports(std::vector<Report>* reports) override;
OperationStatus GetReportForUploading(const UUID& uuid,
const Report** report) override;
OperationStatus RecordUploadAttempt(const Report* report,
@@ -642,14 +640,14 @@ OperationStatus CrashReportDatabaseWin::LookUpCrashReport(const UUID& uuid,
}
OperationStatus CrashReportDatabaseWin::GetPendingReports(
- std::vector<const Report>* reports) {
+ std::vector<Report>* reports) {
scoped_ptr<Metadata> metadata(AcquireMetadata());
return metadata ? metadata->FindReports(ReportState::kPending, reports)
: kDatabaseError;
}
OperationStatus CrashReportDatabaseWin::GetCompletedReports(
- std::vector<const Report>* reports) {
+ std::vector<Report>* reports) {
scoped_ptr<Metadata> metadata(AcquireMetadata());
return metadata ? metadata->FindReports(ReportState::kCompleted, reports)
: kDatabaseError;
« no previous file with comments | « client/crash_report_database_test.cc ('k') | handler/mac/crash_report_upload_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698