Issue 987693002: Implement ErrorScreenHandler::Hide method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 987693002: Implement ErrorScreenHandler::Hide method (Closed)

Created:
5 years, 9 months ago by matthewyuan

Modified:
5 years, 9 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2311

Target Ref:
refs/pending/branch-heads/2311

Project:
chromium

Visibility:
Public.

More Reviews

Description

Implement ErrorScreenHandler::Hide method Also make sure that default hide callback does nothing if parent screen was not set. Follow up to a refactoring https://codereview.chromium.org/872633008/ BUG=462453 TEST=manually, existing browser tests Review URL: https://codereview.chromium.org/982823004 Cr-Commit-Position: refs/heads/master@{#319282} (cherry picked from commit ddb237aaffbd04829c285d994089092ef128d6fb) R=nkostylev@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/f66367b20d024f95b46d38e1bc4e3a2ca7b4a5fe

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/chromeos/login/screens/error_screen.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

matthewyuan

5 years, 9 months ago (2015-03-06 08:01:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f66367b20d024f95b46d38e1bc4e3a2ca7b4a5fe.

Expand Messages | Collapse Messages