Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 982823004: Implement ErrorScreenHandler::Hide method (Closed)

Created:
5 years, 9 months ago by Nikita (slow)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement ErrorScreenHandler::Hide method Also make sure that default hide callback does nothing if parent screen was not set. Follow up to a refactoring https://codereview.chromium.org/872633008/ BUG=462453 TEST=manually, existing browser tests Committed: https://crrev.com/ddb237aaffbd04829c285d994089092ef128d6fb Cr-Commit-Position: refs/heads/master@{#319282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/chromeos/login/screens/error_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nikita (slow)
Based on https://codereview.chromium.org/978213002/ just fixed tests which discovered another bug.
5 years, 9 months ago (2015-03-05 17:29:00 UTC) #2
Denis Kuznetsov (DE-MUC)
lgtm
5 years, 9 months ago (2015-03-05 17:35:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982823004/1
5 years, 9 months ago (2015-03-05 17:37:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 18:03:35 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 18:05:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddb237aaffbd04829c285d994089092ef128d6fb
Cr-Commit-Position: refs/heads/master@{#319282}

Powered by Google App Engine
This is Rietveld 408576698