Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 987553005: Revert of CpuProfiler: enable tests except four failing tests. (Closed)

Created:
5 years, 9 months ago by loislo
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of CpuProfiler: enable tests except four failing tests. (patchset #3 id:100001 of https://codereview.chromium.org/976203003/) Reason for revert: Some tests still flaky Original issue's description: > CpuProfiler: enable tests except four failing tests. > > Four tests are failing due to a problem with no frame ranges. > > BUG= > LOG=n > > Committed: https://crrev.com/2be160e726f2be6272b77e53fbd556aded6024f1 > Cr-Commit-Position: refs/heads/master@{#27035} TBR=yurys@chromium.org,svenpanne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/b2ae7a7594c1bc8f4f400f1f5c72b4cf5e2c8ae1 Cr-Commit-Position: refs/heads/master@{#27037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -30 lines) Patch
M test/cctest/cctest.status View 4 chunks +11 lines, -9 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 4 chunks +8 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
loislo
Created Revert of CpuProfiler: enable tests except four failing tests.
5 years, 9 months ago (2015-03-06 10:18:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987553005/1
5 years, 9 months ago (2015-03-06 10:19:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 10:19:55 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b2ae7a7594c1bc8f4f400f1f5c72b4cf5e2c8ae1 Cr-Commit-Position: refs/heads/master@{#27037}
5 years, 9 months ago (2015-03-06 10:20:10 UTC) #4
yurys
5 years, 9 months ago (2015-03-06 10:40:12 UTC) #5
Message was sent while issue was closed.
Can you provide more details on which tests are flaky for the purpose of
documentation so that we don't need to search them next time?

Powered by Google App Engine
This is Rietveld 408576698