CpuProfiler: enable tests except four failing tests.

CpuProfiler: enable tests except four failing tests.

Four tests are failing due to a problem with no frame ranges.

BUG=
LOG=n

Committed: https://crrev.com/2be160e726f2be6272b77e53fbd556aded6024f1
Cr-Commit-Position: refs/heads/master@{#27035}

Committed: https://crrev.com/84e90b2d0d28229b4107ff350620fc40935c5770
Cr-Commit-Position: refs/heads/master@{#27116}

[loislo, 2015-03-05 13:22:17]

loislo@chromium.org changed reviewers:
+ svenpanne@chromium.org, yurys@chromium.org

[loislo, 2015-03-05 13:22:18]

PTAL

[Sven Panne, 2015-03-05 14:46:13]

LGTM, incomplete tests are better than no tests... ;-)

[Sven Panne, 2015-03-05 14:46:17]

The CQ bit was checked by svenpanne@chromium.org

[commit-bot: I haz the power, 2015-03-05 14:48:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976203003/20001

[loislo, 2015-03-05 14:54:14]

The CQ bit was unchecked by loislo@chromium.org

[yurys, 2015-03-05 14:57:40]

lgtm provided the list of flaky tests is complete.

https://codereview.chromium.org/976203003/diff/20001/test/cctest/test-cpu-pro...
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/976203003/diff/20001/test/cctest/test-cpu-pro...
test/cctest/test-cpu-profiler.cc:1141: delete processor;
Why not use SmartPointer?

[Sven Panne, 2015-03-05 15:05:48]

Good point, I didn't see that..

https://codereview.chromium.org/976203003/diff/20001/test/cctest/test-cpu-pro...
File test/cctest/test-cpu-profiler.cc (right):

https://codereview.chromium.org/976203003/diff/20001/test/cctest/test-cpu-pro...
test/cctest/test-cpu-profiler.cc:1141: delete processor;
On 2015/03/05 14:57:40, yurys wrote:
> Why not use SmartPointer?

Or even simpler: Just avoid pointers altogether here and simply construct the
object directly without new?

[loislo, 2015-03-06 06:38:43]

On 2015/03/05 15:05:48, Sven Panne wrote:
> Good point, I didn't see that..
> 
>
https://codereview.chromium.org/976203003/diff/20001/test/cctest/test-cpu-pro...
> File test/cctest/test-cpu-profiler.cc (right):
> 
>
https://codereview.chromium.org/976203003/diff/20001/test/cctest/test-cpu-pro...
> test/cctest/test-cpu-profiler.cc:1141: delete processor;
> On 2015/03/05 14:57:40, yurys wrote:
> > Why not use SmartPointer?
> 
> Or even simpler: Just avoid pointers altogether here and simply construct the
> object directly without new?

I don't know the exact reason but test is failing on OpenHandle when I construct
the processor on the stack.
Putting it into a scope also doesn't work. So I used SmartPointer.

[loislo, 2015-03-06 06:40:30]

On 2015/03/06 06:38:43, loislo wrote:
> On 2015/03/05 15:05:48, Sven Panne wrote:
> > Good point, I didn't see that..
> > 
> >
>
https://codereview.chromium.org/976203003/diff/20001/test/cctest/test-cpu-pro...
> > File test/cctest/test-cpu-profiler.cc (right):
> > 
> >
>
https://codereview.chromium.org/976203003/diff/20001/test/cctest/test-cpu-pro...
> > test/cctest/test-cpu-profiler.cc:1141: delete processor;
> > On 2015/03/05 14:57:40, yurys wrote:
> > > Why not use SmartPointer?
> > 
> > Or even simpler: Just avoid pointers altogether here and simply construct
the
> > object directly without new?
> 
> I don't know the exact reason but test is failing on OpenHandle when I
construct
> the processor on the stack.
> Putting it into a scope also doesn't work. So I used SmartPointer.

CollectDeoptEvents is failing on arm64 due to a problem in GetDeoptInfo.
bailout_id doesn't match with id from Deoptimizer::GetDeoptimizationId
I'll fix this in another patch.

[loislo, 2015-03-06 06:40:38]

The CQ bit was checked by loislo@chromium.org

[loislo, 2015-03-06 06:40:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
svenpanne@chromium.org, yurys@chromium.org
Link to the patchset: https://codereview.chromium.org/976203003/#ps40001 (title:
"CollectDeoptEvents on arm64 was disabled")

[commit-bot: I haz the power, 2015-03-06 06:41:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976203003/40001

[commit-bot: I haz the power, 2015-03-06 07:17:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-06 07:17:17]

Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/2075)

[loislo, 2015-03-06 07:18:23]

The CQ bit was checked by loislo@chromium.org

[loislo, 2015-03-06 07:18:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
svenpanne@chromium.org, yurys@chromium.org
Link to the patchset: https://codereview.chromium.org/976203003/#ps60001 (title:
"arm")

[commit-bot: I haz the power, 2015-03-06 07:18:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976203003/60001

[loislo, 2015-03-06 07:51:51]

The CQ bit was unchecked by loislo@chromium.org

[loislo, 2015-03-06 08:31:31]

Patchset #4 (id:60001) has been deleted

[loislo, 2015-03-06 08:31:39]

Patchset #3 (id:40001) has been deleted

[loislo, 2015-03-06 08:47:41]

Patchset #3 (id:80001) has been deleted

[loislo, 2015-03-06 10:00:06]

The CQ bit was checked by loislo@chromium.org

[loislo, 2015-03-06 10:00:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
svenpanne@chromium.org, yurys@chromium.org
Link to the patchset: https://codereview.chromium.org/976203003/#ps100001
(title: "arm & arm64 for CollectDeoptEvents")

[commit-bot: I haz the power, 2015-03-06 10:00:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976203003/100001

[commit-bot: I haz the power, 2015-03-06 10:01:45]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2015-03-06 10:02:00]

Patchset 3 (id:??) landed as
https://crrev.com/2be160e726f2be6272b77e53fbd556aded6024f1
Cr-Commit-Position: refs/heads/master@{#27035}

[loislo, 2015-03-06 10:18:54]

A revert of this CL (patchset #3 id:100001) has been created in
https://codereview.chromium.org/987553005/ by loislo@chromium.org.

The reason for reverting is: Some tests still flaky.

[Sven Panne, 2015-03-06 13:50:00]

On 2015/03/06 06:38:43, loislo wrote:
> On 2015/03/05 15:05:48, Sven Panne wrote:
> > Or even simpler: Just avoid pointers altogether here and simply construct
the
> > object directly without new?
> 
> I don't know the exact reason but test is failing on OpenHandle when I
construct
> the processor on the stack.
> Putting it into a scope also doesn't work. So I used SmartPointer.

I had a quick look: ProfilerEventsProcessor directly embeds a 1MB
SamplingCircularQueue, so stack-allocating a ProfilerEventsProcessor probably
doesn't work on most platforms/compilers. Hmmm, this is quite unintuitive and
not very nice... How about dynamically allocating the SamplingCircularQueue and
keep only a (smart) pointer to it in the ProfilerEventsProcessor? This way, the
processor could easily be stack-allocated.

[loislo, 2015-03-10 16:14:03]

The CQ bit was checked by loislo@chromium.org

[loislo, 2015-03-10 16:14:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
svenpanne@chromium.org, yurys@chromium.org
Link to the patchset: https://codereview.chromium.org/976203003/#ps120001
(title: "all other tests which call CheckSimpleBranch(root were disabled")

[commit-bot: I haz the power, 2015-03-10 16:14:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976203003/120001

[commit-bot: I haz the power, 2015-03-10 16:18:27]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2015-03-10 16:18:46]

Patchset 4 (id:??) landed as
https://crrev.com/84e90b2d0d28229b4107ff350620fc40935c5770
Cr-Commit-Position: refs/heads/master@{#27116}