Issue 987393003: Avoid building and archiving the x86-64 pnacl-sz.nexe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 987393003: Avoid building and archiving the x86-64 pnacl-sz.nexe. (Closed)

Created:
5 years, 9 months ago by jvoung (off chromium)

Modified:
5 years, 9 months ago

Reviewers:
Jim Stichnoth, Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master

Target Ref:
refs/heads/master

Project:
nacl

Visibility:
Public.

Avoid building and archiving the x86-64 pnacl-sz.nexe. Forgot to skip this in the previous build CL. It's not useful yet since pnacl-sz doesn't yet target x86-64. There isn't any pruning mechanism in the chrome/chromeos packaging scripts, so just don't build it to avoid taking up the extra bit of space. The real build will have to better separate i686 and x86-64, which is different from pnacl-llc, so things are special cased to only i686. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4091 R=dschuff@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/add84fa7c86ad027cb72ffdbf604a636a004544a

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	pnacl/build.sh	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

jvoung (off chromium)

5 years, 9 months ago (2015-03-10 22:14:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
add84fa7c86ad027cb72ffdbf604a636a004544a (presubmit successful).