pnacl/build.sh - Issue 987393003: Avoid building and archiving the x86-64 pnacl-sz.nexe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pnacl/build.sh

Issue 987393003: Avoid building and archiving the x86-64 pnacl-sz.nexe. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pnacl/build.sh

diff --git a/pnacl/build.sh b/pnacl/build.sh

index f87d5ce5f64ea76eae9521a465235059721043b2..04fc121c42cac51f7ab978c4fa7f336d0fdd92bb 100755

--- a/pnacl/build.sh

+++ b/pnacl/build.sh

@@ -396,9 +396,10 @@ llvm-sb-install() {

local arches=${arch}

if [[ "${arch}" == "universal" ]]; then

arches="${SBTC_ARCHES_ALL}"

- elif [[ "${arch}" == "i686" ]]; then

+ elif [[ "${arch}" == "i686" && "${toolname}" == "pnacl-llc" ]]; then

# LLVM does not separate the i686 and x86_64 backends.

- # Translate twice to get both nexes.

+ # Translate twice to get both nexes, but only for pnacl-llc.

+ # We do not yet have an x86-64 backend for pnacl-sz.

arches="i686 x86_64"

local have_segment_gap="false"

« no previous file with comments | « no previous file | no next file » | no next file with comments »