Issue 987383002: Return a FilePath from Settings::file_path()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 987383002: Return a FilePath from Settings::file_path() (Closed)

Created:
5 years, 9 months ago by Mark Mentovai

Modified:
5 years, 9 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Return a FilePath from Settings::file_path(). This makes it possible to #include "client/settings.h" for the interface even on Windows. Although Settings is not currently implemented on Windows (bug crashpad:13), it’s easier to have the interface declaration available without having to have it be guarded. TEST=crashpad_client_test SettingsTest.* BUG= R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/bdcc1e76257f5578d765dc8577a229b4f43b0a8e

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -9 lines)			Patch
M	client/crash_report_database_test.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	client/settings.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	client/settings.cc	View	1	3 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mark Mentovai

5 years, 9 months ago (2015-03-10 18:26:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
bdcc1e76257f5578d765dc8577a229b4f43b0a8e (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages