client/settings.h - Issue 987383002: Return a FilePath from Settings::file_path()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/settings.h

Issue 987383002: Return a FilePath from Settings::file_path() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/settings.h

diff --git a/client/settings.h b/client/settings.h

index 741561be4925ae2a7e5d17d53439f7ca4df725d7..bab5186a5351374f5c0449a54c6cd61605b56d95 100644

--- a/client/settings.h

+++ b/client/settings.h

@@ -133,7 +133,7 @@ class Settings {

// on success and false on failure, with an error logged.

bool InitializeSettings(FileHandle handle);

- const char* file_path() { return file_path_.value().c_str(); }

+ const base::FilePath& file_path() const { return file_path_; }

base::FilePath file_path_;

« no previous file with comments | « client/crash_report_database_test.cc ('k') | client/settings.cc » ('j') | no next file with comments »