Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1284)

Unified Diff: ui/views/widget/native_widget_mac.mm

Issue 987323002: [MacViews] Frameless app windows: make content view cover title bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test size of web contents, not content view. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/views/widget/native_widget_mac.h ('K') | « ui/views/widget/native_widget_mac.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/native_widget_mac.mm
diff --git a/ui/views/widget/native_widget_mac.mm b/ui/views/widget/native_widget_mac.mm
index 20db395761ee684482da88635be05860871c89e4..a4749db85c17c31a54223449677077225c2f7e5f 100644
--- a/ui/views/widget/native_widget_mac.mm
+++ b/ui/views/widget/native_widget_mac.mm
@@ -85,13 +85,7 @@ void NativeWidgetMac::OnWindowWillClose() {
void NativeWidgetMac::InitNativeWidget(const Widget::InitParams& params) {
ownership_ = params.ownership;
-
- NSInteger style_mask = StyleMaskForParams(params);
- base::scoped_nsobject<NSWindow> window([[NativeWidgetMacNSWindow alloc]
- initWithContentRect:ui::kWindowSizeDeterminedLater
- styleMask:style_mask
- backing:NSBackingStoreBuffered
- defer:YES]);
+ base::scoped_nsobject<NSWindow> window(CreateNSWindow(params));
tapted 2015/03/18 00:06:39 once autoreleased, add retain
jackhou1 2015/03/18 03:44:39 Done.
[window setReleasedWhenClosed:NO]; // Owned by scoped_nsobject.
bridge_->Init(window, params);
@@ -523,6 +517,17 @@ void NativeWidgetMac::RepostNativeEvent(gfx::NativeEvent native_event) {
}
////////////////////////////////////////////////////////////////////////////////
+// NativeWidgetMac, protected:
+
+NSWindow* NativeWidgetMac::CreateNSWindow(Widget::InitParams params) {
+ return [[NativeWidgetMacNSWindow alloc]
+ initWithContentRect:ui::kWindowSizeDeterminedLater
+ styleMask:StyleMaskForParams(params)
+ backing:NSBackingStoreBuffered
+ defer:YES];
+}
+
+////////////////////////////////////////////////////////////////////////////////
// Widget, public:
bool Widget::ConvertRect(const Widget* source,
« ui/views/widget/native_widget_mac.h ('K') | « ui/views/widget/native_widget_mac.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698