ui/views/widget/native_widget_mac.h - Issue 987323002: [MacViews] Frameless app windows: make content view cover title bar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/native_widget_mac.h

Issue 987323002: [MacViews] Frameless app windows: make content view cover title bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test size of web contents, not content view. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/views/cocoa/native_widget_mac_nswindow.h ('K') | « ui/views/cocoa/native_widget_mac_nswindow.mm ('k') | ui/views/widget/native_widget_mac.mm » ('j') | ui/views/widget/native_widget_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/widget/native_widget_mac.h

diff --git a/ui/views/widget/native_widget_mac.h b/ui/views/widget/native_widget_mac.h

index 2ebbcfc3d81fc79ad9cecbc7a3bd74e5ca5ee87f..79a2ee8b7c784c3c24b2cc50b34c7a2e583ab182 100644

--- a/ui/views/widget/native_widget_mac.h

+++ b/ui/views/widget/native_widget_mac.h

@@ -118,6 +118,10 @@ class VIEWS_EXPORT NativeWidgetMac : public internal::NativeWidgetPrivate {

void RepostNativeEvent(gfx::NativeEvent native_event) override;

protected:

+ // Creates the NSWindow that will be passed to the BridgedNativeWidget.

+ // Called by InitNativeWidget.

tapted 2015/03/18 00:06:39 Add comment that the return value will be autorele

jackhou1 2015/03/18 03:44:39 Done.

+ virtual NSWindow* CreateNSWindow(Widget::InitParams params);

tapted 2015/03/18 00:06:39 return gfx::NativeWindow, take const-reference

jackhou1 2015/03/18 03:44:39 Done.

internal::NativeWidgetDelegate* delegate() { return delegate_; }

private: