native_client_sdk/src/tests/nacl_io_test/mount_http_test.cc - Issue 98713004: NaCl: Update revision in DEPS, r12488 -> r12497

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/tests/nacl_io_test/mount_http_test.cc

Issue 98713004: NaCl: Update revision in DEPS, r12488 -> r12497 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix out-of-bounds std::map access in nacl_io testing, and correspondingly broken test. All used pa… Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/tests/nacl_io_test/mount_http_test.cc

diff --git a/native_client_sdk/src/tests/nacl_io_test/mount_http_test.cc b/native_client_sdk/src/tests/nacl_io_test/mount_http_test.cc

index bc7655a8b0f1a27bdc18e843b4d0c18373afa141..735a17ba23717a508d9497227c269dae7923c41a 100644

--- a/native_client_sdk/src/tests/nacl_io_test/mount_http_test.cc

+++ b/native_client_sdk/src/tests/nacl_io_test/mount_http_test.cc

@@ -86,7 +86,7 @@ TEST_P(MountHttpTest, OpenAndCloseServerError) {

EXPECT_TRUE(ppapi_.server_template()->AddError("file", 500));

ScopedMountNode node;

- ASSERT_EQ(ENOENT, mnt_.Open(Path("/file"), O_RDONLY, &node));

+ ASSERT_EQ(EIO, mnt_.Open(Path("/file"), O_RDONLY, &node));

}

TEST_P(MountHttpTest, ReadPartial) {