native_client_sdk/src/tests/nacl_io_test/fake_pepper_interface_url_loader.cc - Issue 98713004: NaCl: Update revision in DEPS, r12488 -> r12497

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/tests/nacl_io_test/fake_pepper_interface_url_loader.cc

Issue 98713004: NaCl: Update revision in DEPS, r12488 -> r12497 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix out-of-bounds std::map access in nacl_io testing, and correspondingly broken test. All used pa… Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: native_client_sdk/src/tests/nacl_io_test/fake_pepper_interface_url_loader.cc

diff --git a/native_client_sdk/src/tests/nacl_io_test/fake_pepper_interface_url_loader.cc b/native_client_sdk/src/tests/nacl_io_test/fake_pepper_interface_url_loader.cc

index f0dc472be687a41e061b4a528760be1ba13f89d6..2d10c971393b1f55c97fffb0f033a33c7a2e60da 100644

--- a/native_client_sdk/src/tests/nacl_io_test/fake_pepper_interface_url_loader.cc

+++ b/native_client_sdk/src/tests/nacl_io_test/fake_pepper_interface_url_loader.cc

@@ -231,7 +231,7 @@ FakeURLLoaderEntity* FakeURLLoaderServer::GetEntity(const std::string& url) {

int FakeURLLoaderServer::GetError(const std::string& url) {

ErrorMap::iterator iter = error_map_.find(url);

- if (iter != error_map_.end())

+ if (iter == error_map_.end())

return 0;

return iter->second;

}

« no previous file with comments | « DEPS ('k') | native_client_sdk/src/tests/nacl_io_test/mount_http_test.cc » ('j') | no next file with comments »