Add a mechanism for command buffer to conditionally allow ES3 enums.

Add a mechanism for command buffer to conditionally allow ES3 enums.

Although ultimately we want to remove validators from command buffer, but the
fastest way to allow an experimental WebGL 2 is actually appending the current
validators.

Appended the BufferTarget as an sample to make sure code generator works.

BUG=463599
TEST=gpu_unittests, webgl conformance tests
R=sievers@chromium.org

Committed: https://crrev.com/ac89bdd636a4a6d8f15415e69b40e546cb020567
Cr-Commit-Position: refs/heads/master@{#319819}

[Zhenyao Mo, 2015-03-09 22:08:21]

sievers: please take a look.
Others: FYI (feel free to review)

[no sievers, 2015-03-09 22:48:20]

lgtm

https://codereview.chromium.org/987123003/diff/1/gpu/command_buffer/build_gle...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/987123003/diff/1/gpu/command_buffer/build_gle...
gpu/command_buffer/build_gles2_cmd_buffer.py:9930: valid_set =
_NAMED_TYPE_INFO[enum]['valid']
Is this actually a set?
You could simply make it one (valid_set = set(_NAMED_TYPE_INFO[enum]['valid'])
Or you could assert that there are no duplicates, which seems like it might be a
mistake anyways.

https://codereview.chromium.org/987123003/diff/1/gpu/command_buffer/service/f...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/987123003/diff/1/gpu/command_buffer/service/f...
gpu/command_buffer/service/feature_info.cc:1071: void FeatureInfo::EnableES3() {
nit: Maybe EnableES3Validators()? Or even EnableUnsafeES3Validators()?

[Zhenyao Mo, 2015-03-09 23:27:03]

https://codereview.chromium.org/987123003/diff/1/gpu/command_buffer/build_gle...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/987123003/diff/1/gpu/command_buffer/build_gle...
gpu/command_buffer/build_gles2_cmd_buffer.py:9930: valid_set =
_NAMED_TYPE_INFO[enum]['valid']
On 2015/03/09 22:48:20, sievers wrote:
> Is this actually a set?
> You could simply make it one (valid_set = set(_NAMED_TYPE_INFO[enum]['valid'])
> Or you could assert that there are no duplicates, which seems like it might be
a
> mistake anyways.

Done. Added an assertion to make sure no duplications.  I was using map the
first time, but it switched a lot of enum orders, which makes reviewing harder,
so I remained using list.

https://codereview.chromium.org/987123003/diff/1/gpu/command_buffer/service/f...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/987123003/diff/1/gpu/command_buffer/service/f...
gpu/command_buffer/service/feature_info.cc:1071: void FeatureInfo::EnableES3() {
On 2015/03/09 22:48:20, sievers wrote:
> nit: Maybe EnableES3Validators()? Or even EnableUnsafeES3Validators()?

Done.

[Zhenyao Mo, 2015-03-09 23:27:50]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2015-03-09 23:27:50]

The patchset sent to the CQ was uploaded after l-g-t-m from sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/987123003/#ps20001 (title:
" ")

[commit-bot: I haz the power, 2015-03-09 23:29:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/987123003/20001

[commit-bot: I haz the power, 2015-03-10 02:09:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-10 02:09:59]

Patchset 2 (id:??) landed as
https://crrev.com/ac89bdd636a4a6d8f15415e69b40e546cb020567
Cr-Commit-Position: refs/heads/master@{#319819}