Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: src/full-codegen.cc

Issue 987083003: [es6] support rest parameters in arrow functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix preparser bug Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/full-codegen.cc
diff --git a/src/full-codegen.cc b/src/full-codegen.cc
index 8721bcd9a69be4989e27775a9a0759979393dff7..3ac85ba66ae24e40ee47490e6b046604a504050e 100644
--- a/src/full-codegen.cc
+++ b/src/full-codegen.cc
@@ -288,6 +288,11 @@ void BreakableStatementChecker::VisitCompareOperation(CompareOperation* expr) {
}
+void BreakableStatementChecker::VisitSpreadOperation(SpreadOperation* expr) {
+ UNREACHABLE();
arv (Not doing code reviews) 2015/03/10 13:44:02 This does not seem right. Shouldn't this be: Visi
caitp (gmail) 2015/03/10 14:47:51 eventually yeah, but for now it's not really neede
+}
+
+
void BreakableStatementChecker::VisitThisFunction(ThisFunction* expr) {
}
@@ -948,6 +953,11 @@ void FullCodeGenerator::VisitBinaryOperation(BinaryOperation* expr) {
}
+void FullCodeGenerator::VisitSpreadOperation(SpreadOperation* node) {
+ UNREACHABLE();
+}
+
+
void FullCodeGenerator::VisitInDuplicateContext(Expression* expr) {
if (context()->IsEffect()) {
VisitForEffect(expr);

Powered by Google App Engine
This is Rietveld 408576698