Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: src/full-codegen.cc

Issue 987083003: [es6] support rest parameters in arrow functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix preparser bug Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/ast.h" 7 #include "src/ast.h"
8 #include "src/ast-numbering.h" 8 #include "src/ast-numbering.h"
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 } 281 }
282 } 282 }
283 283
284 284
285 void BreakableStatementChecker::VisitCompareOperation(CompareOperation* expr) { 285 void BreakableStatementChecker::VisitCompareOperation(CompareOperation* expr) {
286 Visit(expr->left()); 286 Visit(expr->left());
287 Visit(expr->right()); 287 Visit(expr->right());
288 } 288 }
289 289
290 290
291 void BreakableStatementChecker::VisitSpreadOperation(SpreadOperation* expr) {
292 UNREACHABLE();
arv (Not doing code reviews) 2015/03/10 13:44:02 This does not seem right. Shouldn't this be: Visi
caitp (gmail) 2015/03/10 14:47:51 eventually yeah, but for now it's not really neede
293 }
294
295
291 void BreakableStatementChecker::VisitThisFunction(ThisFunction* expr) { 296 void BreakableStatementChecker::VisitThisFunction(ThisFunction* expr) {
292 } 297 }
293 298
294 299
295 void BreakableStatementChecker::VisitSuperReference(SuperReference* expr) {} 300 void BreakableStatementChecker::VisitSuperReference(SuperReference* expr) {}
296 301
297 302
298 #define __ ACCESS_MASM(masm()) 303 #define __ ACCESS_MASM(masm())
299 304
300 bool FullCodeGenerator::MakeCode(CompilationInfo* info) { 305 bool FullCodeGenerator::MakeCode(CompilationInfo* info) {
(...skipping 640 matching lines...) Expand 10 before | Expand all | Expand 10 after
941 return VisitComma(expr); 946 return VisitComma(expr);
942 case Token::OR: 947 case Token::OR:
943 case Token::AND: 948 case Token::AND:
944 return VisitLogicalExpression(expr); 949 return VisitLogicalExpression(expr);
945 default: 950 default:
946 return VisitArithmeticExpression(expr); 951 return VisitArithmeticExpression(expr);
947 } 952 }
948 } 953 }
949 954
950 955
956 void FullCodeGenerator::VisitSpreadOperation(SpreadOperation* node) {
957 UNREACHABLE();
958 }
959
960
951 void FullCodeGenerator::VisitInDuplicateContext(Expression* expr) { 961 void FullCodeGenerator::VisitInDuplicateContext(Expression* expr) {
952 if (context()->IsEffect()) { 962 if (context()->IsEffect()) {
953 VisitForEffect(expr); 963 VisitForEffect(expr);
954 } else if (context()->IsAccumulatorValue()) { 964 } else if (context()->IsAccumulatorValue()) {
955 VisitForAccumulatorValue(expr); 965 VisitForAccumulatorValue(expr);
956 } else if (context()->IsStackValue()) { 966 } else if (context()->IsStackValue()) {
957 VisitForStackValue(expr); 967 VisitForStackValue(expr);
958 } else if (context()->IsTest()) { 968 } else if (context()->IsTest()) {
959 const TestContext* test = TestContext::cast(context()); 969 const TestContext* test = TestContext::cast(context());
960 VisitForControl(expr, test->true_label(), test->false_label(), 970 VisitForControl(expr, test->true_label(), test->false_label(),
(...skipping 857 matching lines...) Expand 10 before | Expand all | Expand 10 after
1818 } 1828 }
1819 codegen_->PrepareForBailoutForId(exit_id_, NO_REGISTERS); 1829 codegen_->PrepareForBailoutForId(exit_id_, NO_REGISTERS);
1820 codegen_->scope_ = saved_scope_; 1830 codegen_->scope_ = saved_scope_;
1821 } 1831 }
1822 1832
1823 1833
1824 #undef __ 1834 #undef __
1825 1835
1826 1836
1827 } } // namespace v8::internal 1837 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698