Delete PasswordStoreX::Get*LoginsImpl

Delete PasswordStoreX::Get*LoginsImpl

As pointed out in https://codereview.chromium.org/906973007/diff/80001/chrome/browser/password_manager/password_store_x.cc#newcode157, instead of overriding Get*LoginsImpl in PasswordStoreX, it is enough to rely on the PasswordStoreDefault implementation of those methods to use PasswordStoreX::Fill*Logins.

The only current difference is that in addition to what Fill*Logins do, PasswordStoreX::Get*LoginsImpl also sorted the logins by origin, to match the order of the login database. There are two ways to fix this:
(1) Move the sorting from Get*LoginsImpl to Fill*Logins.
(2) Drop the sorting.

This CL chose (1). This means that now also PasswordSyncableService::ReadFromPasswordStore, which currently gets the logins unsorted, will perform the sorting. This call should be infrequent enough for this not to be noticeable.r

While (2) would also not break the insides of the password manager, it would degrade the UI (try to find a login in an unsorted list of them). For the reference, the CL which added the sorting was https://codereview.chromium.org/6953010.

BUG=324291
Committed: https://crrev.com/f7f365094f1aba4e9e46e574d85fabcdac62827e
Cr-Commit-Position: refs/heads/master@{#319617}

[vabr (Chromium), 2015-03-09 09:42:24]

vabr@chromium.org changed reviewers:
+ engedy@chromium.org

[vabr (Chromium), 2015-03-09 09:42:24]

Hi Balázs,

While I'm finishing addressing your comments on
https://codereview.chromium.org/906973007/, this CL is a spin-off of one of your
comments there. Could you please have a look?

Thanks!
Vaclav

[engedy, 2015-03-09 09:46:35]

LGTM, thanks for the clean-up!

[vabr (Chromium), 2015-03-09 10:49:03]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2015-03-09 10:49:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/986983002/1

[commit-bot: I haz the power, 2015-03-09 11:15:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-09 11:15:07]

Failed to apply the patch.

[commit-bot: I haz the power, 2015-03-09 11:15:11]

The CQ bit was unchecked by commit-bot@chromium.org

[vabr (Chromium), 2015-03-09 12:40:52]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2015-03-09 12:40:52]

The patchset sent to the CQ was uploaded after l-g-t-m from engedy@chromium.org
Link to the patchset: https://codereview.chromium.org/986983002/#ps20001 (title:
"Just rebased")

[commit-bot: I haz the power, 2015-03-09 12:41:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/986983002/20001

[commit-bot: I haz the power, 2015-03-09 13:12:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-09 13:14:24]

Patchset 2 (id:??) landed as
https://crrev.com/f7f365094f1aba4e9e46e574d85fabcdac62827e
Cr-Commit-Position: refs/heads/master@{#319617}