Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: chrome/browser/password_manager/password_store_x.h

Issue 986983002: Delete PasswordStoreX::Get*LoginsImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Just rebased Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_store_x.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 const autofill::PasswordForm& form) override; 87 const autofill::PasswordForm& form) override;
88 password_manager::PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl( 88 password_manager::PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl(
89 base::Time delete_begin, 89 base::Time delete_begin,
90 base::Time delete_end) override; 90 base::Time delete_end) override;
91 password_manager::PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl( 91 password_manager::PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl(
92 base::Time delete_begin, 92 base::Time delete_begin,
93 base::Time delete_end) override; 93 base::Time delete_end) override;
94 ScopedVector<autofill::PasswordForm> FillMatchingLogins( 94 ScopedVector<autofill::PasswordForm> FillMatchingLogins(
95 const autofill::PasswordForm& form, 95 const autofill::PasswordForm& form,
96 AuthorizationPromptPolicy prompt_policy) override; 96 AuthorizationPromptPolicy prompt_policy) override;
97 void GetAutofillableLoginsImpl(
98 scoped_ptr<PasswordStore::GetLoginsRequest> request) override;
99 void GetBlacklistLoginsImpl(
100 scoped_ptr<PasswordStore::GetLoginsRequest> request) override;
101 bool FillAutofillableLogins( 97 bool FillAutofillableLogins(
102 ScopedVector<autofill::PasswordForm>* forms) override; 98 ScopedVector<autofill::PasswordForm>* forms) override;
103 bool FillBlacklistLogins( 99 bool FillBlacklistLogins(
104 ScopedVector<autofill::PasswordForm>* forms) override; 100 ScopedVector<autofill::PasswordForm>* forms) override;
105 101
106 // Sort logins by origin, like the ORDER BY clause in login_database.cc.
107 void SortLoginsByOrigin(std::vector<autofill::PasswordForm*>* list);
108
109 // Check to see whether migration is necessary, and perform it if so. 102 // Check to see whether migration is necessary, and perform it if so.
110 void CheckMigration(); 103 void CheckMigration();
111 104
112 // Return true if we should try using the native backend. 105 // Return true if we should try using the native backend.
113 bool use_native_backend() { return !!backend_.get(); } 106 bool use_native_backend() { return !!backend_.get(); }
114 107
115 // Return true if we can fall back on the default store, warning the first 108 // Return true if we can fall back on the default store, warning the first
116 // time we call it when falling back is necessary. See |allow_fallback_|. 109 // time we call it when falling back is necessary. See |allow_fallback_|.
117 bool allow_default_store(); 110 bool allow_default_store();
118 111
(...skipping 10 matching lines...) Expand all
129 // Whether we should allow falling back to the default store. If there is 122 // Whether we should allow falling back to the default store. If there is
130 // nothing to migrate, then the first attempt to use the native store will 123 // nothing to migrate, then the first attempt to use the native store will
131 // be the first time we try to use it and we should allow falling back. If 124 // be the first time we try to use it and we should allow falling back. If
132 // we have migrated successfully, then we do not allow falling back. 125 // we have migrated successfully, then we do not allow falling back.
133 bool allow_fallback_; 126 bool allow_fallback_;
134 127
135 DISALLOW_COPY_AND_ASSIGN(PasswordStoreX); 128 DISALLOW_COPY_AND_ASSIGN(PasswordStoreX);
136 }; 129 };
137 130
138 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_ 131 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_store_x.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698